Merge pull request #2837 from dotty-staging/change-purity-check

Refine purity check

Author: DarkDimius

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -1711,7 +1711,7 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
         traverse(stats ++ rest)
       case stat :: rest =>
         val stat1 = typed(stat)(ctx.exprContext(stat, exprOwner))
-        if (!ctx.isAfterTyper && isPureExpr(stat1))
+        if (!ctx.isAfterTyper && isPureExpr(stat1) && !stat1.tpe.isRef(defn.UnitClass))
           ctx.warning(em"a pure expression does nothing in statement position", stat.pos)
         buf += stat1
         traverse(rest)

tests/neg/customArgs/xfatalWarnings.scala

@@ -4,4 +4,8 @@ object xfatalWarnings {
   opt match { // error when running with -Xfatal-warnings
     case None =>
   }
-}
+
+  object Test {
+    while (true) {} // should be ok. no "pure expression does nothing in statement position" issued.
+  }
+}