Drop DottyPredef.assertFail.

Although it is a useful thing to have, there is nothing specific to
Scala 3 about it. Therefore, it does not carry its weight in
`DottyPredef`.

Author: sjrd

compiler/test/dotty/tools/backend/jvm/InlineBytecodeTests.scala

@@ -54,7 +54,7 @@ class InlineBytecodeTests extends DottyBytecodeTest {
     val sources = List(
       mkSource("assert(true)", "()"),
       mkSource("assert(true, ???)", "()"),
-      mkSource("assert(false)", "assertFail()")
+      mkSource("assert(false)", "{ throw new java.lang.AssertionError(\"assertion failed\") }")
     )
     for (source <- sources)
       checkBCode(source) { dir =>

docs/docs/internals/debug-macros.md

@@ -37,7 +37,6 @@ Here is the usually stacktrace for unresolved symbols in pickling:
 
 ```
 [error] java.lang.AssertionError: assertion failed: unresolved symbols: value pos (line 5565) when pickling scalatest/scalatest-test.dotty/target/scala-0.17/src_managed/test/org/scalatest/AssertionsSpec.scala
-[error] 	at dotty.DottyPredef$.assertFail(DottyPredef.scala:16)
 [error] 	at dotty.tools.dotc.core.tasty.TreePickler.pickle(TreePickler.scala:699)
 [error] 	at dotty.tools.dotc.transform.Pickler.run$$anonfun$10$$anonfun$8(Pickler.scala:60)
 [error] 	at dotty.runtime.function.JProcedure1.apply(JProcedure1.java:15)

library/src/dotty/DottyPredef.scala

@@ -5,17 +5,14 @@ object DottyPredef {
 
   inline final def assert(inline assertion: Boolean, inline message: => Any): Unit = {
     if (!assertion)
-      assertFail(message)
+      throw new java.lang.AssertionError("assertion failed: " + message)
   }
 
   transparent inline final def assert(inline assertion: Boolean): Unit = {
     if (!assertion)
-      assertFail()
+      throw new java.lang.AssertionError("assertion failed")
   }
 
-  def assertFail(): Nothing = throw new java.lang.AssertionError("assertion failed")
-  def assertFail(message: => Any): Nothing = throw new java.lang.AssertionError("assertion failed: " + message)
-
   inline final def implicitly[T](implicit ev: T): T = ev
 
   /** Used to mark code blocks as being expressions, instead of being taken as part of anonymous classes and the like.

scala3doc/resources/dotty_res/scripts/hljs-scala3.js

@@ -25,7 +25,7 @@ function highlightDotty(hljs) {
       'if implicit import lazy match new object package private protected override return '+
       'sealed then throw trait true try type val var while with yield =>> => ?=> <: >: _ ? <-',
     literal: 'true false null this super',
-    built_in: '??? asInstanceOf isInstanceOf assert assertFail implicitly locally summon .nn'
+    built_in: '??? asInstanceOf isInstanceOf assert implicitly locally summon .nn'
   }
   const modifiers = 'abstract|final|implicit|override|private|protected|sealed'
 

stdlib-bootstrapped-tasty-tests/test/BootstrappedStdLibTASYyTest.scala

@@ -146,7 +146,6 @@ object BootstrappedStdLibTASYyTest:
   def compileBlacklist = List[String](
     // See #10048
     // failed: java.lang.AssertionError: assertion failed: class Boolean
-    //   at dotty.DottyPredef$.assertFail(DottyPredef.scala:17)
     //   at dotty.tools.backend.jvm.BCodeHelpers$BCInnerClassGen.assertClassNotArrayNotPrimitive(BCodeHelpers.scala:247)
     //   at dotty.tools.backend.jvm.BCodeHelpers$BCInnerClassGen.getClassBTypeAndRegisterInnerClass(BCodeHelpers.scala:265)
     //   at dotty.tools.backend.jvm.BCodeHelpers$BCInnerClassGen.getClassBTypeAndRegisterInnerClass$(BCodeHelpers.scala:210)

tests/pos/main-method-scheme-class-based.scala

@@ -62,7 +62,7 @@ class main extends MainAnnotation:
     /** Issue an error, and return an uncallable getter */
     private def error(msg: String): () => Nothing =
       errors += msg
-      () => assertFail("trying to get invalid argument")
+      () => throw new AssertionError("trying to get invalid argument")
 
     /** The next argument index */
     private var argIdx: Int = 0

tests/pos/matches.scala

@@ -5,7 +5,7 @@ object Test:
     case 3 => "?"
   match
     case "OK" =>
-    case "?" => assertFail()
+    case "?" => throw new AssertionError()
 
   val x = 4
   if 2 < 3
@@ -17,4 +17,4 @@ object Test:
           case _ => false
   then
     println("ok")
-end Test
+end Test

tests/run/Signals.scala

@@ -53,7 +53,7 @@ class BankAccount:
       val b = myBalance()
       myBalance() = b - amount
       myBalance()
-    else assertFail("insufficient funds")
+    else throw new AssertionError("insufficient funds")
 end BankAccount
 
 @main def Test() =

tests/run/Signals1.scala

@@ -66,7 +66,7 @@ class BankAccount:
       val b = myBalance()
       myBalance() = b - amount
       myBalance()
-    else assertFail("insufficient funds")
+    else throw new AssertionError("insufficient funds")
 end BankAccount
 
 @main def Test() =

tests/run/decorators/main.scala

@@ -32,7 +32,7 @@ class main extends EntryPoint.Annotation:
       /** Issue an error, and return an uncallable getter */
       private def error(msg: String): () => Nothing =
         errors += msg
-        () => assertFail("trying to get invalid argument")
+        () => throw new AssertionError("trying to get invalid argument")
 
       /** The next argument index */
       private var argIdx: Int = 0