Make checkNonCyclic force less

smarter · smarter · commit 9fcceb4e9f0e · 2019-07-15T19:04:35.000+01:00
`checkInfo` is just the identity on ClassInfo so no need to force the
info in this case. This avoids some cyclic reference errors which
started appearing after other completions-related changes in this PR.
diff --git a/compiler/src/dotty/tools/dotc/typer/Checking.scala b/compiler/src/dotty/tools/dotc/typer/Checking.scala
@@ -258,7 +258,7 @@ object Checking {
             if (locked.contains(tp) || tp.symbol.infoOrCompleter.isInstanceOf[NoCompleter])
               throw CyclicReference(tp.symbol)
             locked += tp
-            try checkInfo(tp.info)
+            try if (!tp.symbol.isClass) checkInfo(tp.info)
             finally locked -= tp
             tp.withPrefix(pre1)
           }

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ object Checking {`
`258`	`258`	`if (locked.contains(tp) \|\| tp.symbol.infoOrCompleter.isInstanceOf[NoCompleter])`
`259`	`259`	`throw CyclicReference(tp.symbol)`
`260`	`260`	`locked += tp`
`261`		`- try checkInfo(tp.info)`
	`261`	`+ try if (!tp.symbol.isClass) checkInfo(tp.info)`
`262`	`262`	`finally locked -= tp`
`263`	`263`	`tp.withPrefix(pre1)`
`264`	`264`	`}`