Move definition classes to documentation

Author: romanowski

scala3doc/resources/dotty_res/styles/scalastyle.css

@@ -367,7 +367,7 @@ dl.attributes > dt.implicit {
 }
 dl.attributes > dd {
   display: block;
-  padding-left: 5em;
+  padding-left: 6em;
   margin-bottom: 5px;
   min-height: 15px;
 }
@@ -462,7 +462,7 @@ footer .pull-right {
 
 .expand .modifiers {
   display: inline-table;
-  min-width: 4em;
+  min-width: 7em;
 }
 
 .signature {
@@ -519,6 +519,10 @@ footer .pull-right {
   margin-left: 6.5em;
 }
 
+.doc code {
+  padding: 0;
+}
+
 .documentableElement:hover {
   cursor: pointer;
   border-left: 0.25em solid var(--leftbar-bg);

scala3doc/src/dotty/dokka/translators/ScalaContentBuilder.scala

@@ -494,10 +494,6 @@ class ScalaPageContentBuilder(
               case Some(dri: DRI) => SLink(name, dri)
               case None => name
             Signature("Exported from ", signatureName)
-          case Origin.Overrides(overridenMembers) => 
-            def intersperse(xs: Seq[SLink]): Seq[(String | SLink)] = 
-              xs.flatMap(Seq(_, " -> ")).dropRight(1).asInstanceOf[Seq[(String | SLink)]] // dropRight returns `Seq[Object]`
-            Signature("Definition classes: ").join(Signature(intersperse(overridenMembers.map(SLink(_, _))):_*))
           case _ => Nil
         }
         val styles: Set[Style] = if documentable.deprecated.isDefined then Set(TextStyle.Strikethrough) else Set.empty

scala3doc/src/dotty/dokka/translators/ScalaPageCreator.scala

@@ -205,7 +205,7 @@ class ScalaPageCreator(
 
     def contentForConstructors(c: DClass) =
        b.documentableTab("Constructors")(
-        DocumentableGroup(None, c.membersBy(_.kind.isInstanceOf[Kind.Constructor])._1)
+        DocumentableGroup(None, c.membersBy(_.kind.isInstanceOf[Kind.Constructor]))
       )
 
 

scala3doc/src/dotty/renderers/MemberRenderer.scala

@@ -29,6 +29,15 @@ class MemberRenderer(signatureRenderer: SignatureRenderer, buildNode: ContentNod
 
   def tableRow(name: String, content: AppliedTag) = Seq(dt(name), dd(content))
 
+  def defintionClasses(m: Member) = m.origin match
+    case Origin.Overrides(defs) =>
+      def renderDef(d: Overriden): Seq[TagArg] =
+        Seq(signatureRenderer.renderLink(d.name, d.dri), " -> ")
+
+      val nodes: Seq[TagArg] = defs.flatMap(renderDef).dropRight(1) // drop trailing arrow
+      tableRow("Definition Classes", div(nodes:_*))
+
+    case _ => Nil
 
   def docAttributes(m: Member): Seq[AppliedTag] =
 
@@ -102,6 +111,7 @@ class MemberRenderer(signatureRenderer: SignatureRenderer, buildNode: ContentNod
           docAttributes(m),
           companion(m),
           deprecation(m),
+          defintionClasses(m),
           source(m),
         )
       )