Use MutableSymbolMap update instead of put

Author: nicolasstucki

compiler/src/dotty/tools/backend/jvm/GenBCode.scala

@@ -43,7 +43,7 @@ class GenBCode extends Phase {
   private val superCallsMap = newMutableSymbolMap[Set[ClassSymbol]]
   def registerSuperCall(sym: Symbol, calls: ClassSymbol) = {
     val old = superCallsMap.getOrElse(sym, Set.empty)
-    superCallsMap.put(sym, old + calls)
+    superCallsMap.update(sym, old + calls)
   }
 
   def outputDir(implicit ctx: Context): AbstractFile =

compiler/src/dotty/tools/dotc/core/Comments.scala

@@ -33,7 +33,7 @@ object Comments {
     def docstring(sym: Symbol): Option[Comment] = _docstrings.get(sym)
 
     def addDocstring(sym: Symbol, doc: Option[Comment]): Unit =
-      doc.map(d => _docstrings.put(sym, d))
+      doc.map(d => _docstrings.update(sym, d))
   }
 
   /** A `Comment` contains the unformatted docstring as well as a position

compiler/src/dotty/tools/dotc/transform/localopt/Devalify.scala

@@ -43,7 +43,7 @@ class Devalify extends Optimisation {
     tp.foreachPart(x => x match {
       case TermRef(NoPrefix, _) =>
         val b4 = timesUsedAsType.getOrElseUpdate(x.termSymbol, 0)
-        timesUsedAsType.put(x.termSymbol, b4 + 1)
+        timesUsedAsType.update(x.termSymbol, b4 + 1)
       case _ =>
     })
   }
@@ -55,7 +55,7 @@ class Devalify extends Optimisation {
 
       dropCasts(valdef.rhs) match {
         case t: Tree if readingOnlyVals(t) =>
-          copies.put(valdef.symbol, valdef.rhs)
+          copies.update(valdef.symbol, valdef.rhs)
         case _ =>
       }
       visitType(valdef.symbol.info)
@@ -77,7 +77,7 @@ class Devalify extends Optimisation {
     case t: TypeApply   => t.args.foreach(x => visitType(x.tpe))
     case t: RefTree =>
       val b4 = used.getOrElseUpdate(t.symbol, 0)
-      used.put(t.symbol, b4 + 1)
+      used.update(t.symbol, b4 + 1)
     case _ =>
   }
 

compiler/src/dotty/tools/dotc/transform/localopt/InlineLabelsCalledOnce.scala

@@ -31,11 +31,11 @@ class InlineLabelsCalledOnce extends Optimisation {
           isRecursive = true
       }
       if (!isRecursive)
-        defined.put(d.symbol, d)
+        defined.update(d.symbol, d)
 
     case t: Apply if t.symbol.is(Label) =>
       val b4 = timesUsed.getOrElseUpdate(t.symbol, 0)
-      timesUsed.put(t.symbol, b4 + 1)
+      timesUsed.update(t.symbol, b4 + 1)
 
     case _ =>
   }
@@ -55,7 +55,7 @@ class InlineLabelsCalledOnce extends Optimisation {
 
     case d: DefDef if usedOnce(d) =>
       simplify.println(s"Dropping labeldef (used once) ${d.name} ${timesUsed.get(d.symbol)}")
-      defined.put(d.symbol, d)
+      defined.update(d.symbol, d)
       EmptyTree
 
     case d: DefDef if neverUsed(d) =>

compiler/src/dotty/tools/dotc/transform/localopt/RemoveUnnecessaryNullChecks.scala

@@ -62,11 +62,11 @@ import scala.collection.mutable
           case t: Literal => t.const.value != null
 
           case t: Ident if !t.symbol.owner.isClass =>
-            checkGood.put(target, checkGood.getOrElse(target, Set.empty) + t.symbol)
+            checkGood.update(target, checkGood.getOrElse(target, Set.empty) + t.symbol)
             true
 
           case t: Apply if !t.symbol.owner.isClass =>
-            checkGood.put(target, checkGood.getOrElse(target, Set.empty) + t.symbol)
+            checkGood.update(target, checkGood.getOrElse(target, Set.empty) + t.symbol)
             true
 
           case t: Typed =>

compiler/src/dotty/tools/dotc/transform/localopt/Varify.scala

@@ -38,21 +38,21 @@ import scala.collection.mutable
 
   def visitor(implicit ctx: Context): Tree => Unit = {
     case t: ValDef if t.symbol.is(Param) =>
-      paramsTimesUsed.put(t.symbol, 0)
+      paramsTimesUsed.update(t.symbol, 0)
 
     case t: ValDef if t.symbol.is(Mutable) =>
       t.rhs.foreachSubTree { subtree =>
         if (paramsTimesUsed.contains(subtree.symbol) &&
           t.symbol.info.widenDealias <:< subtree.symbol.info.widenDealias) {
           val newSet = possibleRenames.getOrElse(t.symbol, Set.empty) + subtree.symbol
-          possibleRenames.put(t.symbol, newSet)
+          possibleRenames.update(t.symbol, newSet)
         }
       }
 
     case t: RefTree if paramsTimesUsed.contains(t.symbol) =>
       val param = t.symbol
       val current = paramsTimesUsed.get(param)
-      current foreach { c => paramsTimesUsed.put(param, c + 1) }
+      current foreach { c => paramsTimesUsed.update(param, c + 1) }
 
     case _ =>
   }