Merge pull request #17 from pikinier20/scaladoc/header-fixes

Header review fixes

Author: fanixus96

scaladoc-js/main/src/versions-dropdown/DropdownHandler.scala

@@ -66,7 +66,6 @@ end DropdownHandler
 @JSExportTopLevel("dropdownHandler")
 def dropdownHandler(e: Event) =
   e.stopPropagation()
-  console.log("clikc")
   if document.getElementById("version-dropdown").getElementsByTagName("a").size > 0 &&
      window.getSelection.toString.length == 0 then
     document.getElementById("version-dropdown").classList.toggle("expanded")

scaladoc/resources/dotty_res/images/icon-buttons/sun/dark/active.svg

@@ -48,6 +48,10 @@
   content: url("../../../../images/icon-buttons/moon/light/selected.svg");
 }
 
+#theme-toggle.icon-button:focus::after {
+  content: url("../../../../images/icon-buttons/moon/light/focus.svg");
+}
+
 .theme-dark #theme-toggle.icon-button::after {
   content: url("../../../../images/icon-buttons/sun/dark/default.svg");
 }
@@ -72,6 +76,10 @@
   content: url("../../../../images/icon-buttons/sun/dark/selected.svg");
 }
 
+.theme-dark #theme-toggle.icon-button:focus::after {
+  content: url("../../../../images/icon-buttons/sun/dark/focus.svg");
+}
+
 /* search-toggle button */
 
 #search-toggle.icon-button::after {

scaladoc/resources/dotty_res/styles/theme/components/button/icon-button.css

@@ -9,9 +9,11 @@
   box-shadow: 0px 10px 38px -10px var(--shadow-first),
     0px 10px 20px -15px var(--shadow-second),
     inset 0px 0px 0px 1px var(--shadow-inset);
-    border: none;
+  border: none;
   border-radius: 4px;
   z-index: 2;
+  justify-content: center;
+  align-items: center;
 }
 
 .floating-button:disabled {
@@ -120,6 +122,6 @@
 
 @media (max-width: 1024px) {
   .floating-button {
-    display: block;
+    display: flex;
   }
 }

scaladoc/resources/dotty_res/styles/theme/layout/floatingButton.css

@@ -48,7 +48,7 @@
   text-decoration: none;
   color: var(--action-primary-content-default);
   border-bottom: 1px solid var(--border-default);
-  padding: calc(1.5 * var(--base-spacing)) calc(2 * var(--base-spacing));
+  padding: calc(2.5 * var(--base-spacing)) calc(2 * var(--base-spacing));
   display: flex;
   align-items: center;
 }

scaladoc/resources/dotty_res/styles/theme/layout/mobileMenu.css

@@ -2,10 +2,9 @@
   overflow-y: auto;
   overflow-x: hidden;
   width: 100%;
-  height: 100%;
+  height: calc(100% - calc(11 * var(--base-spacing)));
   padding-left: calc(1.5 * var(--base-spacing));
   padding-right: calc(1.5 * var(--base-spacing));
-  padding-bottom: calc(3 * var(--base-spacing));
   box-sizing: border-box;
 }
 

scaladoc/resources/dotty_res/styles/theme/layout/sideMenu.css

@@ -240,8 +240,8 @@ class HtmlRenderer(rootPackage: Member, members: Map[DRI, Member])(using ctx: Do
             a(href := "https://www.scala-lang.org/blog/", cls := "text-button") (
               "Community",
             ),
-          button(id := "theme-toggle", cls := "icon-button"),
-          button(id := "mobile-menu-toggle", cls := "icon-button hamburger"),
+          span(id := "theme-toggle", cls := "icon-button"),
+          span(id := "mobile-menu-toggle", cls := "icon-button hamburger"),
         ),
       ),
       div(id := "mobile-menu")(
@@ -275,7 +275,7 @@ class HtmlRenderer(rootPackage: Member, members: Map[DRI, Member])(using ctx: Do
           span(id := "mobile-theme-toggle", cls := "mobile-menu-item mode"),
         )
       ),
-      button(id := "mobile-sidebar-toggle", cls := "floating-button"),
+      span(id := "mobile-sidebar-toggle", cls := "floating-button"),
       div(id := "leftColumn", cls := "body-small")(
         Seq(
           div(cls:= "switcher-container")(