Move NoInit checks to Mixin

Author: nicolasstucki

compiler/src/dotty/tools/dotc/core/Definitions.scala

@@ -971,10 +971,7 @@ class Definitions {
    *  trait gets screwed up. Therefore, it is mandatory that FunctionXXL
    *  is treated as a NoInit trait.
    */
-  private lazy val NoInitClasses = NotRuntimeClasses + FunctionXXLClass
-
-  def isNoInitClass(cls: Symbol): Boolean =
-    cls.is(NoInitsTrait) || NoInitClasses.contains(cls) || isFunctionClass(cls)
+  lazy val NoInitClasses = NotRuntimeClasses + FunctionXXLClass
 
   def isPolymorphicAfterErasure(sym: Symbol) =
      (sym eq Any_isInstanceOf) || (sym eq Any_asInstanceOf)

compiler/src/dotty/tools/dotc/transform/Mixin.scala

@@ -182,7 +182,7 @@ class Mixin extends MiniPhase with SymTransformer { thisPhase =>
         if (defn.NotRuntimeClasses.contains(baseCls) || baseCls.is(NoInitsTrait)) Nil
         else call :: Nil
       case None =>
-        if (defn.isNoInitClass(baseCls)) Nil
+        if (baseCls.is(NoInitsTrait) || defn.NoInitClasses.contains(baseCls) || defn.isFunctionClass(baseCls)) Nil
         else {
           //println(i"synth super call ${baseCls.primaryConstructor}: ${baseCls.primaryConstructor.info}")
           transformFollowingDeep(superRef(baseCls.primaryConstructor).appliedToNone) :: Nil