Merge pull request #12184 from dotty-staging/fix-12170

Detect given bindings in for generators

Author: odersky

compiler/src/dotty/tools/dotc/ast/Desugar.scala

@@ -1554,14 +1554,21 @@ object desugar {
         }
       }
 
+      /** Is `pat` of the form `x`, `x T`, or `given T`? when used as the lhs of a generator,
+       *  these are all considered irrefutable.
+       */
+      def isVarBinding(pat: Tree): Boolean = pat match
+        case pat @ Bind(_, pat1) if pat.mods.is(Given) => isVarBinding(pat1)
+        case IdPattern(_) => true
+        case _ => false
+
       def needsNoFilter(gen: GenFrom): Boolean =
         if (gen.checkMode == GenCheckMode.FilterAlways) // pattern was prefixed by `case`
           false
-        else (
-          gen.checkMode != GenCheckMode.FilterNow ||
-          IdPattern.unapply(gen.pat).isDefined ||
-          isIrrefutable(gen.pat, gen.expr)
-        )
+        else
+          gen.checkMode != GenCheckMode.FilterNow
+          || isVarBinding(gen.pat)
+          || isIrrefutable(gen.pat, gen.expr)
 
       /** rhs.name with a pattern filter on rhs unless `pat` is irrefutable when
        *  matched against `rhs`.

tests/run/i12170.scala

@@ -0,0 +1,13 @@
+import scala.compiletime.error
+
+object BadFilters:
+  inline def withFilter(f: Int => Boolean): BadFilters.type = error("Unexpected withFilter call")
+  def foreach(f: Int => Unit): Unit = f(42)
+
+@main def Test =
+  for
+    x: Int <- BadFilters
+  do println(x)
+  for
+    given Int <- BadFilters
+  do println(summon[Int])