Merge pull request #3811 from dotty-staging/fix-#2333

Fix #2333: Check if class is deprecated

Author: nicolasstucki

compiler/src/dotty/tools/dotc/typer/RefChecks.scala

@@ -879,7 +879,9 @@ class RefChecks extends MiniPhase { thisPhase =>
   }
 
   override def transformNew(tree: New)(implicit ctx: Context) = {
-    currentLevel.enterReference(tree.tpe.typeSymbol, tree.pos)
+    val sym = tree.tpe.typeSymbol
+    checkUndesiredProperties(sym, tree.pos)
+    currentLevel.enterReference(sym, tree.pos)
     tree
   }
 }

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -186,6 +186,7 @@ class CompilationTests extends ParallelTesting {
     compileFile("../tests/neg-custom-args/xfatalWarnings.scala", defaultOptions.and("-Xfatal-warnings")) +
     compileFile("../tests/neg-custom-args/pureStatement.scala", defaultOptions.and("-Xfatal-warnings")) +
     compileFile("../tests/neg-custom-args/i3589-a.scala", defaultOptions.and("-Xfatal-warnings")) +
+    compileFile("../tests/neg-custom-args/i2333.scala", defaultOptions.and("-Xfatal-warnings")) +
     compileFile("../tests/neg-custom-args/phantom-overload.scala", allowDoubleBindings) +
     compileFile("../tests/neg-custom-args/phantom-overload-2.scala", allowDoubleBindings) +
     compileFile("../tests/neg-custom-args/structural.scala", defaultOptions.and("-Xfatal-warnings"))

tests/neg-custom-args/i2333.scala

@@ -0,0 +1,8 @@
+@deprecated("bla", "2.11.0") class Foo {
+  def this(x: Int) = this()
+}
+
+object Test {
+  new Foo // error: deprecated
+  new Foo(1) // error: deprecated
+}