Rid of compiletime.testing package object

Point the compiler to the compiletime.testing package

instead of package object

Author: anatoliykmetyuk

compiler/src/dotty/tools/dotc/core/Definitions.scala

@@ -231,9 +231,9 @@ class Definitions {
     @tu lazy val Compiletime_constValue   : Symbol = CompiletimePackageObject.requiredMethod("constValue")
     @tu lazy val Compiletime_constValueOpt: Symbol = CompiletimePackageObject.requiredMethod("constValueOpt")
     @tu lazy val Compiletime_summonFrom   : Symbol = CompiletimePackageObject.requiredMethod("summonFrom")
-  @tu lazy val CompiletimeTestingPackageObject: Symbol = requiredModule("scala.compiletime.testing.package")
-    @tu lazy val CompiletimeTesting_typeChecks: Symbol = CompiletimeTestingPackageObject.requiredMethod("typeChecks")
-    @tu lazy val CompiletimeTesting_typeCheckErrors: Symbol = CompiletimeTestingPackageObject.requiredMethod("typeCheckErrors")
+  @tu lazy val CompiletimeTestingPackage: Symbol = requiredPackage("scala.compiletime.testing")
+    @tu lazy val CompiletimeTesting_typeChecks: Symbol = CompiletimeTestingPackage.requiredMethod("typeChecks")
+    @tu lazy val CompiletimeTesting_typeCheckErrors: Symbol = CompiletimeTestingPackage.requiredMethod("typeCheckErrors")
     @tu lazy val CompiletimeTesting_ErrorClass: ClassSymbol = requiredClass("scala.compiletime.testing.Error")
     @tu lazy val CompiletimeTesting_Error: Symbol = requiredModule("scala.compiletime.testing.Error")
       @tu lazy val CompiletimeTesting_Error_apply = CompiletimeTesting_Error.requiredMethod(nme.apply)

compiler/src/dotty/tools/dotc/typer/Inliner.scala

@@ -72,7 +72,7 @@ object Inliner {
    */
   def inlineCall(tree: Tree)(using Context): Tree = {
     if tree.symbol.denot != SymDenotations.NoDenotation
-      && tree.symbol.owner.companionModule == defn.CompiletimeTestingPackageObject
+      && tree.symbol.effectiveOwner == defn.CompiletimeTestingPackage.moduleClass
     then
       if (tree.symbol == defn.CompiletimeTesting_typeChecks) return Intrinsics.typeChecks(tree)
       if (tree.symbol == defn.CompiletimeTesting_typeCheckErrors) return Intrinsics.typeCheckErrors(tree)

library/src/scala/compiletime/testing/package.scala

@@ -1,33 +1,31 @@
 package scala.compiletime
+package testing
 
-package object testing {
+/** Whether the code type checks in the current context?
+ *
+ *  @param code The code to be type checked
+ *
+ *  @return false if the code has syntax error or type error in the current context, otherwise returns true.
+ *
+ *  The code should be a sequence of expressions or statements that may appear in a block.
+ */
+inline def typeChecks(inline code: String): Boolean =
+  // implemented in package dotty.tools.dotc.typer.Inliner.Intrinsics
+  error("Compiler bug: `typeChecks` was not checked by the compiler")
 
-  /** Whether the code type checks in the current context?
-   *
-   *  @param code The code to be type checked
-   *
-   *  @return false if the code has syntax error or type error in the current context, otherwise returns true.
-   *
-   *  The code should be a sequence of expressions or statements that may appear in a block.
-   */
-  inline def typeChecks(inline code: String): Boolean =
-    // implemented in package dotty.tools.dotc.typer.Inliner.Intrinsics
-    error("Compiler bug: `typeChecks` was not checked by the compiler")
-
-  /** Whether the code type checks in the current context? If not,
-   *  returns a list of errors encountered on compilation.
-   *  IMPORTANT: No stability guarantees are provided on the format of these
-   *  errors. This means the format and the API may change from
-   *  version to version. This API is to be used for testing purposes
-   *  only.
-   *
-   *  @param code The code to be type checked
-   *
-   *  @return a list of errors encountered during parsing and typechecking.
-   *
-   *  The code should be a sequence of expressions or statements that may appear in a block.
-   */
-  inline def typeCheckErrors(inline code: String): List[Error] =
-    // implemented in package dotty.tools.dotc.typer.Inliner.Intrinsics
-    error("Compiler bug: `typeCheckErrors` was not checked by the compiler")
-}
+/** Whether the code type checks in the current context? If not,
+ *  returns a list of errors encountered on compilation.
+ *  IMPORTANT: No stability guarantees are provided on the format of these
+ *  errors. This means the format and the API may change from
+ *  version to version. This API is to be used for testing purposes
+ *  only.
+ *
+ *  @param code The code to be type checked
+ *
+ *  @return a list of errors encountered during parsing and typechecking.
+ *
+ *  The code should be a sequence of expressions or statements that may appear in a block.
+ */
+inline def typeCheckErrors(inline code: String): List[Error] =
+  // implemented in package dotty.tools.dotc.typer.Inliner.Intrinsics
+  error("Compiler bug: `typeCheckErrors` was not checked by the compiler")