Strengthen the MiMa filters for TastyCore and Interfaces

Author: nicolasstucki

project/Build.scala

@@ -531,7 +531,8 @@ object Build {
     settings(commonMiMaSettings).
     settings(
       versionScheme := Some("semver-spec"),
-      mimaBinaryIssueFilters ++= MiMaFilters.Interfaces,
+      mimaForwardIssueFilters := MiMaFilters.Interfaces.ForwardsBreakingChanges,
+      mimaBackwardIssueFilters := MiMaFilters.Interfaces.BackwardsBreakingChanges,
       customMimaReportBinaryIssues("MiMaFilters.Interfaces"),
     )
 
@@ -1118,7 +1119,7 @@ object Build {
       mimaCheckDirection := "both",
       mimaBackwardIssueFilters := Scala2LibraryBootstrappedMiMaFilters.BackwardsBreakingChanges,
       mimaForwardIssueFilters := Scala2LibraryBootstrappedMiMaFilters.ForwardsBreakingChanges,
-      customMimaReportBinaryIssues("Scala2LibraryBootstrappedMiMaFilters.{BackwardsBreakingChanges, ForwardsBreakingChanges}"),
+      customMimaReportBinaryIssues("Scala2LibraryBootstrappedMiMaFilters"),
       mimaPreviousArtifacts += "org.scala-lang" % "scala-library" % stdlibBootstrappedVersion,
       mimaExcludeAnnotations ++= Seq(
         "scala.annotation.experimental",
@@ -2107,7 +2108,7 @@ object Build {
   private def customMimaReportBinaryIssues(issueFilterLocation: String) = mimaReportBinaryIssues := {
     mimaReportBinaryIssues.result.value match {
       case Inc(inc: Incomplete) =>
-        streams.value.log.error(s"\n$issueFilterLocation are used as filters\n ")
+        streams.value.log.error(s"\nFilers in $issueFilterLocation are used in this check.\n ")
         throw inc
       case Value(v) => v
     }
@@ -2179,7 +2180,7 @@ object Build {
           },
           mimaForwardIssueFilters := MiMaFilters.Scala3Library.ForwardsBreakingChanges,
           mimaBackwardIssueFilters := MiMaFilters.Scala3Library.BackwardsBreakingChanges,
-          customMimaReportBinaryIssues("MiMaFilters.Scala3Library.{ForwardsBreakingChanges, BackwardsBreakingChanges}"),
+          customMimaReportBinaryIssues("MiMaFilters.Scala3Library"),
         )
       } else base
     }
@@ -2193,7 +2194,8 @@ object Build {
         versionScheme := Some("semver-spec"),
         if (mode == Bootstrapped) Def.settings(
           commonMiMaSettings,
-          mimaBinaryIssueFilters ++= MiMaFilters.TastyCore,
+          mimaForwardIssueFilters := MiMaFilters.TastyCore.ForwardsBreakingChanges,
+          mimaBackwardIssueFilters := MiMaFilters.TastyCore.BackwardsBreakingChanges,
           customMimaReportBinaryIssues("MiMaFilters.TastyCore"),
         ) else {
           Nil

project/MiMaFilters.scala

@@ -41,12 +41,13 @@ object MiMaFilters {
         ProblemFilters.exclude[MissingFieldProblem]("scala.runtime.stdLibPatches.language#experimental.relaxedExtensionImports"),
       ),
     )
+
     val BackwardsBreakingChanges: Map[String, Seq[ProblemFilter]] = Map(
       // In general we should never have backwards incompatible changes in the library.
       // Only exceptional cases should be added here.
 
       // Breaking changes since last reference version
-      Build.previousDottyVersion -> Seq.empty,
+      Build.previousDottyVersion -> Seq.empty, // We should never break backwards compatibility
 
       // Breaking changes since last LTS
       Build.ltsDottyVersion -> Seq(
@@ -66,9 +67,38 @@ object MiMaFilters {
     )
   }
 
-  val TastyCore: Seq[ProblemFilter] = Seq(
-  )
-  val Interfaces: Seq[ProblemFilter] = Seq(
-  )
+  object TastyCore {
+    val ForwardsBreakingChanges: Map[String, Seq[ProblemFilter]] = Map(
+      // Additions that require a new minor version of tasty core
+      Build.previousDottyVersion -> Seq(
+      ),
+
+      // Additions since last LTS
+      Build.ltsDottyVersion -> Seq(
+      )
+    )
+
+    val BackwardsBreakingChanges: Map[String, Seq[ProblemFilter]] = Map(
+      // Breaking changes since last LTS
+      Build.ltsDottyVersion -> Seq.empty // We should never break backwards compatibility
+    )
+  }
+
+  object Interfaces {
+    val ForwardsBreakingChanges: Map[String, Seq[ProblemFilter]] = Map(
+      // Additions that require a new minor version of interfaces
+      Build.previousDottyVersion -> Seq(
+      ),
+
+      // Additions since last LTS
+      Build.ltsDottyVersion -> Seq(
+      )
+    )
+
+    val BackwardsBreakingChanges: Map[String, Seq[ProblemFilter]] = Map(
+      // Breaking changes since last LTS
+      Build.ltsDottyVersion -> Seq.empty // We should never break backwards compatibility
+    )
+  }
 
 }