Make Unused flag a term flag only

Author: nicolasstucki

compiler/src/dotty/tools/dotc/ast/untpd.scala

@@ -118,7 +118,7 @@ object untpd extends Trees.Instance[Untyped] with UntypedTreeInfo {
 
     case class Implicit() extends Mod(Flags.ImplicitCommon)
 
-    case class Unused() extends Mod(Flags.UnusedCommon)
+    case class Unused() extends Mod(Flags.Unused)
 
     case class Final() extends Mod(Flags.Final)
 

compiler/src/dotty/tools/dotc/core/Flags.scala

@@ -368,9 +368,7 @@ object Flags {
   final val Enum = commonFlag(40, "<enum>")
 
   /** Labeled with `unused` modifier (unused value)  */
-  final val UnusedCommon = commonFlag(42, "unused")
-  final val Unused = UnusedCommon.toTermFlags
-  final val UnusedType = UnusedCommon.toTypeFlags
+  final val Unused = termFlag(42, "unused")
 
   // Flags following this one are not pickled
 

compiler/src/dotty/tools/dotc/typer/Checking.scala

@@ -383,7 +383,6 @@ object Checking {
         fail(CannotHaveSameNameAs(sym, cls, CannotHaveSameNameAs.CannotBeOverridden))
         sym.setFlag(Private) // break the overriding relationship by making sym Private
       }
-    checkApplicable(UnusedType, !sym.is(UnusedType))
     if (sym.is(Unused))
       checkApplicable(Unused, !sym.is(MutableOrLazy))
   }