Merge pull request #5426 from Kobenko/issues/4948

Fix #4948: final implicit class can be overridden

Author: allanrenucci

compiler/src/dotty/tools/dotc/ast/Desugar.scala

@@ -293,7 +293,7 @@ object desugar {
     val impl @ Template(constr0, parents, self, _) = cdef.rhs
     val mods = cdef.mods
     val companionMods = mods
-        .withFlags((mods.flags & AccessFlags).toCommonFlags)
+        .withFlags((mods.flags & (AccessFlags | Final)).toCommonFlags)
         .withMods(Nil)
 
     var defaultGetters: List[Tree] = Nil

tests/neg/overrideFinalImplicit.scala

@@ -0,0 +1,7 @@
+class Implicits {
+  final implicit class FooExtender(foo: String)
+}
+
+class Test extends Implicits {
+  override implicit def FooExtender(foo: String) = super.FooExtender(foo) // error
+}