Merge pull request #5634 from dotty-staging/fix-#5328

Fix #5328: Disallow repeated type application

Author: odersky

compiler/src/dotty/tools/dotc/typer/Applications.scala

@@ -881,6 +881,8 @@ trait Applications extends Compatibility { self: Typer with Dynamic =>
     typedExpr(tree.fun, PolyProto(typedArgs, pt)) match {
       case ExtMethodApply(app) =>
         app
+      case _: TypeApply if !ctx.isAfterTyper =>
+        errorTree(tree, "illegal repeated type application")
       case typedFn =>
         typedFn.tpe.widen match {
           case pt: PolyType =>

tests/neg/i5328.scala

@@ -0,0 +1,8 @@
+class C[X, Y] { def apply[Z](x: X, y: Y, z: Z) = (x, y, z) }
+
+object Test {
+  def f[X, Y]: C[X, Y] = new C[X, Y]
+  f[Int, Boolean][String](1, true, "") // OK
+  f[X = Int](1, true, "") // OK, Y and Z are inferred
+  f[X = Int][String](1, true, "") // error: illegal repeated type application
+}

tests/neg/namedTypeParams.scala

@@ -12,5 +12,11 @@ object Test {
   def f[X, Y](x: X, y: Y): Int = ???
 
   f[X = Int, String](1, "") // error // error
-  f[X = Int][X = Int][Y = String](1, "") // error
+  f[X = Int][X = Int][Y = String](1, "") // error: illegal repeated type application
+
+  f[X = Int][Y = String](1, "") // error: illegal repeated type application
+  f[X = Int][String](1, "") // error: illegal repeated type application
+
+  f[Y = String][X = Int](1, "") // error: illegal repeated type application
+  f[Y = String][Int](1, "") // error: illegal repeated type application
 }

tests/pos/i5328.scala

@@ -0,0 +1,8 @@
+class C[X, Y] { def apply[Z](x: X, y: Y, z: Z) = (x, y, z) }
+
+object Test {
+  def f[X, Y, Z]: C[X, Y] = new C[X, Y]
+  f[Int, Boolean, Any][String](1, true, "") // OK
+  f[X = Int](1, true, "") // OK, Y and Z are inferred
+  f[Z = Any, X = Int](1, true, "") // OK
+}

tests/pos/namedTypeParams.scala

@@ -7,9 +7,5 @@ object Test {
   f[X = Int](1, "")
   f[Y = String](1, "")
 
-  f[X = Int][Y = String](1, "")
-  f[X = Int][String](1, "")
 
-  f[Y = String][X = Int](1, "")
-  f[Y = String][Int](1, "")
 }