Merge pull request #4675 from dotty-staging/fix-tasty-pattern-ref

Fix Tasty reflect patterns with select trees

Author: nicolasstucki

compiler/src/dotty/tools/dotc/tastyreflect/TastyImpl.scala

@@ -474,7 +474,7 @@ object TastyImpl extends scala.tasty.Tasty {
     object Value extends ValueExtractor {
       def unapply(x: Pattern)(implicit ctx: Context): Option[Term] = x match {
         case lit: tpd.Literal @unchecked => Some(lit)
-        case ident: tpd.Ident @unchecked if ident.isTerm => Some(ident)
+        case ref: tpd.RefTree @unchecked if ref.isTerm => Some(ref)
         case _ => None
       }
     }

tests/pos/simpleMatchRef.decompiled

@@ -0,0 +1,12 @@
+/** Decompiled from out/posTestFromTasty/pos/simpleMatchRef/Foo.class */
+class Foo() {
+  val X: scala.Int = scala.Predef.???
+  def foo(x: scala.Any): scala.Unit = x match {
+    case this.X =>
+      scala.Predef.println("a")
+    case Y =>
+      scala.Predef.println("b")
+  }
+}
+/** Decompiled from out/posTestFromTasty/pos/simpleMatchRef/Y.class */
+object Y

tests/pos/simpleMatchRef.scala

@@ -0,0 +1,10 @@
+
+class Foo {
+  val X: Int = ???
+  def foo(x: Any): Unit = x match {
+    case X => println("a")
+    case Y => println("b")
+  }
+}
+
+object Y