Merge pull request #3198 from dotty-staging/fix-#3168

Fix #3168: Don't insert apply if tree has method type

Author: odersky

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -1799,6 +1799,11 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
    */
   def tryInsertApplyOrImplicit(tree: Tree, pt: ProtoType)(fallBack: => Tree)(implicit ctx: Context): Tree = {
 
+    def isMethod(tree: Tree) = tree.tpe match {
+      case ref: TermRef => ref.denot.alternatives.forall(_.info.widen.isInstanceOf[MethodicType])
+      case _ => false
+    }
+
     def isSyntheticApply(tree: Tree): Boolean = tree match {
       case tree: Select => tree.getAttachment(InsertedApply).isDefined
       case Apply(fn, _) => fn.getAttachment(InsertedApply).isDefined
@@ -1821,7 +1826,7 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
         pt.markAsDropped()
         tree
       case _ =>
-        if (isApplyProto(pt) || isSyntheticApply(tree)) tryImplicit
+        if (isApplyProto(pt) || isMethod(tree) || isSyntheticApply(tree)) tryImplicit
         else tryEither(tryApply(_))((_, _) => tryImplicit)
      }
   }

tests/neg/insertapply.scala

@@ -0,0 +1,6 @@
+class C {
+  def apply: C
+}
+object Test {
+  (new C)(22) // error: does not take parameters
+}

tests/pos/i3168.scala

@@ -0,0 +1,14 @@
+object Test {
+  class C {
+    def foo(x: Int) = 1
+    def foo(x: Double) = 2
+  }
+
+  implicit class COps(val x: C) {
+    def foo(x: String) = 3
+  }
+
+  def test: Unit = {
+    (new C).foo("Hello")
+  }
+}

tests/pos/i3189.scala

@@ -0,0 +1,9 @@
+class Test[A](action: A => A) {
+  def this() = this(a => a)
+  def go(x: A) = action(x)
+}
+
+object Test extends App {
+  assert(new Test[Int]().go(3) == 3)
+}
+