Merge pull request #3541 from dotty-staging/fix-all-warinings

Fix all warnings and add -Xfatal-warnings

Author: allanrenucci

compiler/src/dotty/tools/backend/jvm/GenBCode.scala

@@ -115,12 +115,11 @@ class GenBCodePipeline(val entryPoints: List[Symbol], val int: DottyBackendInter
     case class Item2(arrivalPos:   Int,
                      mirror:       asm.tree.ClassNode,
                      plain:        asm.tree.ClassNode,
-                     bean:         asm.tree.ClassNode,
                      outFolder:    scala.tools.nsc.io.AbstractFile) {
       def isPoison = { arrivalPos == Int.MaxValue }
     }
 
-    private val poison2 = Item2(Int.MaxValue, null, null, null, null)
+    private val poison2 = Item2(Int.MaxValue, null, null, null)
     private val q2 = new _root_.java.util.LinkedList[Item2]
 
     /* ---------------- q3 ---------------- */
@@ -140,7 +139,6 @@ class GenBCodePipeline(val entryPoints: List[Symbol], val int: DottyBackendInter
     case class Item3(arrivalPos: Int,
                      mirror:     SubItem3,
                      plain:      SubItem3,
-                     bean:       SubItem3,
                      outFolder:  scala.tools.nsc.io.AbstractFile) {
 
       def isPoison  = { arrivalPos == Int.MaxValue }
@@ -152,7 +150,7 @@ class GenBCodePipeline(val entryPoints: List[Symbol], val int: DottyBackendInter
         else 1
       }
     }
-    private val poison3 = Item3(Int.MaxValue, null, null, null, null)
+    private val poison3 = Item3(Int.MaxValue, null, null, null)
     private val q3 = new java.util.PriorityQueue[Item3](1000, i3comparator)
 
     /*
@@ -243,21 +241,12 @@ class GenBCodePipeline(val entryPoints: List[Symbol], val int: DottyBackendInter
             store.visitAttribute(dataAttr)
           }
 
-        // -------------- bean info class, if needed --------------
-        val beanC =
-          if (claszSymbol hasAnnotation int.BeanInfoAttr) {
-            beanInfoCodeGen.genBeanInfoClass(
-              claszSymbol, cunit,
-              int.symHelper(claszSymbol).fieldSymbols,
-              int.symHelper(claszSymbol).methodSymbols
-            )
-          } else null
 
         // ----------- hand over to pipeline-2
 
         val item2 =
           Item2(arrivalPos,
-            mirrorC, plainC, beanC,
+            mirrorC, plainC,
             outF)
 
         q2 add item2 // at the very end of this method so that no Worker2 thread starts mutating before we're done.
@@ -307,19 +296,17 @@ class GenBCodePipeline(val entryPoints: List[Symbol], val int: DottyBackendInter
           cw.toByteArray
         }
 
-        val Item2(arrivalPos, mirror, plain, bean, outFolder) = item
+        val Item2(arrivalPos, mirror, plain, outFolder) = item
 
         val mirrorC = if (mirror == null) null else SubItem3(mirror.name, getByteArray(mirror))
         val plainC  = SubItem3(plain.name, getByteArray(plain))
-        val beanC   = if (bean == null)   null else SubItem3(bean.name, getByteArray(bean))
 
         if (AsmUtils.traceSerializedClassEnabled && plain.name.contains(AsmUtils.traceSerializedClassPattern)) {
           if (mirrorC != null) AsmUtils.traceClass(mirrorC.jclassBytes)
           AsmUtils.traceClass(plainC.jclassBytes)
-          if (beanC != null) AsmUtils.traceClass(beanC.jclassBytes)
         }
 
-        q3 add Item3(arrivalPos, mirrorC, plainC, beanC, outFolder)
+        q3 add Item3(arrivalPos, mirrorC, plainC, outFolder)
 
       }
 
@@ -453,7 +440,6 @@ class GenBCodePipeline(val entryPoints: List[Symbol], val int: DottyBackendInter
           val outFolder = item.outFolder
           sendToDisk(item.mirror, outFolder)
           sendToDisk(item.plain,  outFolder)
-          sendToDisk(item.bean,   outFolder)
           expected += 1
         }
       }

compiler/src/dotty/tools/dotc/Run.scala

@@ -143,7 +143,7 @@ class Run(comp: Compiler, ictx: Context) {
   }
 
   private sealed trait PrintedTree
-  private final case class SomePrintedTree(phase: String, tree: String) extends PrintedTree
+  private /*final*/ case class SomePrintedTree(phase: String, tree: String) extends PrintedTree
   private object NoPrintedTree extends PrintedTree
 
   private def printTree(last: PrintedTree)(implicit ctx: Context): PrintedTree = {

compiler/src/dotty/tools/dotc/core/Symbols.scala

@@ -31,6 +31,7 @@ import collection.mutable
 import io.AbstractFile
 import language.implicitConversions
 import util.{NoSource, DotClass}
+import scala.collection.JavaConverters._
 
 /** Creation methods for symbols */
 trait Symbols { this: Context =>
@@ -724,25 +725,14 @@ object Symbols {
 
     def clear(): Unit = value.clear()
 
-    def filter(p: ((Symbol, T)) => Boolean): Map[Symbol, T] = {
-      import scala.collection.JavaConversions._
-      value.toMap.filter(p)
-    }
+    def filter(p: ((Symbol, T)) => Boolean): Map[Symbol, T] =
+      value.asScala.toMap.filter(p)
 
-    def iterator: Iterator[(Symbol, T)] = {
-      import scala.collection.JavaConversions._
-      value.iterator
-    }
+    def iterator: Iterator[(Symbol, T)] = value.asScala.iterator
 
-    def keysIterator: Iterator[Symbol] = {
-      import scala.collection.JavaConversions._
-      value.keySet().iterator
-    }
+    def keysIterator: Iterator[Symbol] = value.keySet().asScala.iterator
 
-    def toMap: Map[Symbol, T] = {
-      import scala.collection.JavaConversions._
-      value.toMap
-    }
+    def toMap: Map[Symbol, T] = value.asScala.toMap
   }
 
   @inline def newMutableSymbolMap[T]: MutableSymbolMap[T] =