Add a todo comment

noti0na1 · noti0na1 · commit 54b7aa5ff6cf · 2022-02-24T16:53:30.000-05:00
diff --git a/compiler/src/dotty/tools/dotc/core/Contexts.scala b/compiler/src/dotty/tools/dotc/core/Contexts.scala
@@ -839,7 +839,7 @@ object Contexts {
     gadt = EmptyGadtConstraint
   }
 
-  @sharable object NoContext extends Context(null.asInstanceOf) {
+  @sharable object NoContext extends Context((null: ContextBase | Null).uncheckedNN) {
     source = NoSource
     override val implicits: ContextualImplicits = new ContextualImplicits(Nil, null, false)(this)
   }
diff --git a/compiler/src/dotty/tools/dotc/core/GadtConstraint.scala b/compiler/src/dotty/tools/dotc/core/GadtConstraint.scala
@@ -107,6 +107,7 @@ final class ProperGadtConstraint private(
               params.indexOf(tp.symbol) match {
                 case -1 =>
                   mapping(tp.symbol) match {
+                    // TODO: Improve flow typing so that ascription becomes redundant, see #11967
                     case tv: TypeVar => tv.origin
                     case null => tp
                   }

Original file line number	Diff line number	Diff line change
`@@ -839,7 +839,7 @@ object Contexts {`
`839`	`839`	`gadt = EmptyGadtConstraint`
`840`	`840`	`}`
`841`	`841`
`842`		`- @sharable object NoContext extends Context(null.asInstanceOf) {`
	`842`	`+ @sharable object NoContext extends Context((null: ContextBase \| Null).uncheckedNN) {`
`843`	`843`	`source = NoSource`
`844`	`844`	`override val implicits: ContextualImplicits = new ContextualImplicits(Nil, null, false)(this)`
`845`	`845`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ final class ProperGadtConstraint private(`
`107`	`107`	`params.indexOf(tp.symbol) match {`
`108`	`108`	`case -1 =>`
`109`	`109`	`mapping(tp.symbol) match {`
	`110`	`+ // TODO: Improve flow typing so that ascription becomes redundant, see #11967`
`110`	`111`	`case tv: TypeVar => tv.origin`
`111`	`112`	`case null => tp`
`112`	`113`	`}`