Merge pull request #14046 from dotty-staging/fix-14039

Remove strong assertion when inlining

Author: odersky

compiler/src/dotty/tools/dotc/typer/Inliner.scala

@@ -1540,7 +1540,6 @@ class Inliner(call: tpd.Tree, rhsToInline: tpd.Tree)(using Context) {
       inlineIfNeeded(tryInlineArg(tree.asInstanceOf[tpd.Tree]) `orElse` super.typedIdent(tree, pt))
 
     override def typedSelect(tree: untpd.Select, pt: Type)(using Context): Tree = {
-      assert(tree.hasType, tree)
       val qual1 = typed(tree.qualifier, shallowSelectionProto(tree.name, pt, this))
       val resNoReduce = untpd.cpy.Select(tree)(qual1, tree.name).withType(tree.typeOpt)
       val reducedProjection = reducer.reduceProjection(resNoReduce)

tests/neg-macros/i14039/Macro_1.scala

@@ -0,0 +1,7 @@
+import scala.quoted.*
+
+object Macro:
+  inline def apply(): Any = ${Macro.impl}
+
+  def impl(using Quotes): Expr[Any] =
+    quotes.reflect.report.errorAndAbort("my message")

tests/neg-macros/i14039/Test_2.scala

@@ -0,0 +1,5 @@
+class Dsl {
+  val entries = Seq.newBuilder[Any]
+  inline def get(): Unit = entries += Macro.apply()
+  def test = get() // error
+}

tests/neg/i14039.check

@@ -0,0 +1,4 @@
+-- Error: tests/neg/i14039.scala:4:14 ----------------------------------------------------------------------------------
+4 |def test = get() // error
+  |           ^^^^^
+  |           my error

tests/neg/i14039.scala

@@ -0,0 +1,4 @@
+val entries = Seq.newBuilder[Any]
+inline def error(): Any = compiletime.error("my error")
+inline def get(): Unit = entries += error()
+def test = get() // error