Homogenize Symbol methods in CompilerInterface

Author: nicolasstucki

compiler/src/dotty/tools/dotc/tastyreflect/ReflectionCompilerInterface.scala

@@ -1516,12 +1516,14 @@ class ReflectionCompilerInterface(val rootContext: core.Contexts.Context) extend
   def Symbol_isAbstractType(self: Symbol)(given Context): Boolean = self.isAbstractType
   def Symbol_isClassConstructor(self: Symbol)(given Context): Boolean = self.isClassConstructor
 
-  def isPackageDefSymbol(symbol: Symbol)(given Context): Boolean =
+  def Symbol_isPackageDefSymbol(symbol: Symbol)(given Context): Boolean =
     symbol.is(core.Flags.Package)
 
-  def isTypeSymbol(symbol: Symbol)(given Context): Boolean = symbol.isType
+  def Symbol_isTypeSymbol(symbol: Symbol)(given Context): Boolean =
+    symbol.isType
 
-  def isClassDefSymbol(symbol: Symbol)(given Context): Boolean = symbol.isClass
+  def Symbol_isClassDefSymbol(symbol: Symbol)(given Context): Boolean =
+    symbol.isClass
 
   def Symbol_fields(self: Symbol)(given Context): List[Symbol] =
     self.unforcedDecls.filter(isField)
@@ -1564,26 +1566,28 @@ class ReflectionCompilerInterface(val rootContext: core.Contexts.Context) extend
 
   private def isField(sym: Symbol)(given Context): Boolean = sym.isTerm && !sym.is(Flags.Method)
 
-  def Symbol_of(fullName: String)(given ctx: Context): Symbol = ctx.requiredClass(fullName)
+  def Symbol_of(fullName: String)(given ctx: Context): Symbol =
+    ctx.requiredClass(fullName)
 
-  def isTypeDefSymbol(symbol: Symbol)(given Context): Boolean =
+  def Symbol_isTypeDefSymbol(symbol: Symbol)(given Context): Boolean =
     symbol.isType && !symbol.is(core.Flags.Case)
 
   def Symbol_isTypeParam(self: Symbol)(given Context): Boolean =
     self.isTypeParam
 
-  def isTypeBindSymbol(symbol: Symbol)(given Context): Boolean =
+  def Symbol_isTypeBindSymbol(symbol: Symbol)(given Context): Boolean =
     symbol.isType && symbol.is(core.Flags.Case)
 
-  def isTermSymbol(symbol: Symbol)(given Context): Boolean = symbol.isTerm
+  def Symbol_isTermSymbol(symbol: Symbol)(given Context): Boolean =
+    symbol.isTerm
 
-  def isDefDefSymbol(symbol: Symbol)(given Context): Boolean =
+  def Symbol_isDefDefSymbol(symbol: Symbol)(given Context): Boolean =
     symbol.isTerm && symbol.is(core.Flags.Method)
 
   def Symbol_signature(self: Symbol)(given Context): Signature =
     self.signature
 
-  def isValDefSymbol(symbol: Symbol)(given Context): Boolean =
+  def Symbol_isValDefSymbol(symbol: Symbol)(given Context): Boolean =
     symbol.isTerm && !symbol.is(core.Flags.Method) && !symbol.is(core.Flags.Case)
 
   def Symbol_moduleClass(self: Symbol)(given Context): Symbol = self.moduleClass
@@ -1592,12 +1596,12 @@ class ReflectionCompilerInterface(val rootContext: core.Contexts.Context) extend
 
   def Symbol_companionModule(self: Symbol)(given Context): Symbol = self.companionModule
 
-  def isBindSymbol(symbol: Symbol)(given Context): Boolean =
+  def Symbol_isBindSymbol(symbol: Symbol)(given Context): Boolean =
     symbol.isTerm && symbol.is(core.Flags.Case)
 
   def Symbol_noSymbol(given ctx: Context): Symbol = core.Symbols.NoSymbol
 
-  def isNoSymbol(symbol: Symbol)(given Context): Boolean = symbol eq core.Symbols.NoSymbol
+  def Symbol_isNoSymbol(symbol: Symbol)(given Context): Boolean = symbol eq core.Symbols.NoSymbol
 
   //
   // FLAGS

library/src/scala/tasty/reflect/CompilerInterface.scala

@@ -1239,11 +1239,11 @@ trait CompilerInterface {
 
   def Symbol_isDefinedInCurrentRun(self: Symbol)(given ctx: Context): Boolean
 
-  def isPackageDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isPackageDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
-  def isTypeSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isTypeSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
-  def isClassDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isClassDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
   /** Fields directly declared in the class */
   def Symbol_fields(self: Symbol)(given ctx: Context): List[Symbol]
@@ -1268,20 +1268,20 @@ trait CompilerInterface {
 
   def Symbol_of(fullName: String)(given ctx: Context): Symbol
 
-  def isTypeDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isTypeDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
   def Symbol_isTypeParam(self: Symbol)(given ctx: Context): Boolean
 
-  def isTypeBindSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isTypeBindSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
-  def isTermSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isTermSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
-  def isDefDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isDefDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
   /** Signature of this definition */
   def Symbol_signature(self: Symbol)(given ctx: Context): Signature
 
-  def isValDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isValDefSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
   /** The class symbol of the companion module class */
   def Symbol_moduleClass(self: Symbol)(given ctx: Context): Symbol
@@ -1292,11 +1292,11 @@ trait CompilerInterface {
   /** The symbol of the companion module */
   def Symbol_companionModule(self: Symbol)(given ctx: Context): Symbol
 
-  def isBindSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isBindSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
   def Symbol_noSymbol(given ctx: Context): Symbol
 
-  def isNoSymbol(symbol: Symbol)(given ctx: Context): Boolean
+  def Symbol_isNoSymbol(symbol: Symbol)(given ctx: Context): Boolean
 
   //
   // FLAGS

library/src/scala/tasty/reflect/SymbolOps.scala

@@ -95,15 +95,15 @@ trait SymbolOps extends Core {
     def isAbstractType(given ctx: Context): Boolean = internal.Symbol_isAbstractType(self)
     def isClassConstructor(given ctx: Context): Boolean = internal.Symbol_isClassConstructor(self)
 
-    def isType(given ctx: Context): Boolean = internal.isTypeSymbol(self)
-    def isTerm(given ctx: Context): Boolean = internal.isTermSymbol(self)
-    def isValDef(given ctx: Context): Boolean = internal.isValDefSymbol(self)
-    def isDefDef(given ctx: Context): Boolean = internal.isDefDefSymbol(self)
-    def isTypeDef(given ctx: Context): Boolean = internal.isTypeDefSymbol(self)
-    def isClassDef(given ctx: Context): Boolean = internal.isClassDefSymbol(self)
-    def isBind(given ctx: Context): Boolean = internal.isBindSymbol(self)
-    def isPackageDef(given ctx: Context): Boolean = internal.isPackageDefSymbol(self)
-    def isNoSymbol(given ctx: Context): Boolean = internal.isNoSymbol(self)
+    def isType(given ctx: Context): Boolean = internal.Symbol_isTypeSymbol(self)
+    def isTerm(given ctx: Context): Boolean = internal.Symbol_isTermSymbol(self)
+    def isValDef(given ctx: Context): Boolean = internal.Symbol_isValDefSymbol(self)
+    def isDefDef(given ctx: Context): Boolean = internal.Symbol_isDefDefSymbol(self)
+    def isTypeDef(given ctx: Context): Boolean = internal.Symbol_isTypeDefSymbol(self)
+    def isClassDef(given ctx: Context): Boolean = internal.Symbol_isClassDefSymbol(self)
+    def isBind(given ctx: Context): Boolean = internal.Symbol_isBindSymbol(self)
+    def isPackageDef(given ctx: Context): Boolean = internal.Symbol_isPackageDefSymbol(self)
+    def isNoSymbol(given ctx: Context): Boolean = internal.Symbol_isNoSymbol(self)
 
     /** Fields directly declared in the class */
     def fields(given ctx: Context): List[Symbol] =