Merge pull request #3787 from dotty-staging/fix-#3745

Fix #3745: check for double imports

Author: nicolasstucki

compiler/src/dotty/tools/dotc/transform/PostTyper.scala

@@ -278,10 +278,14 @@ class PostTyper extends MacroTransform with IdentityDenotTransformer { thisPhase
           )
         case Import(expr, selectors) =>
           val exprTpe = expr.tpe
+          val seen = mutable.Set.empty[Name]
           def checkIdent(ident: untpd.Ident): Unit = {
             val name = ident.name.asTermName
             if (name != nme.WILDCARD && !exprTpe.member(name).exists && !exprTpe.member(name.toTypeName).exists)
               ctx.error(NotAMember(exprTpe, name, "value"), ident.pos)
+            if (seen(ident.name))
+              ctx.error(s"${ident.show} is renamed twice", ident.pos)
+            seen += ident.name
           }
           selectors.foreach {
             case ident: untpd.Ident                 => checkIdent(ident)

tests/neg/i3745a.scala

@@ -0,0 +1 @@
+import scala.collection.{ Seq, Seq } // error: Seq is renamed twice

tests/neg/i3745b.scala

@@ -0,0 +1 @@
+import scala.collection.{ Seq, Seq => _ } // error: Seq is renamed twice

tests/neg/i3745c.scala

@@ -0,0 +1 @@
+import scala.collection.{ Seq => A, Seq => B } // error: Seq is renamed twice