Compile quote patterns directly into QuotePattern AST (#18133)

Fixes #14708
Fixes #16522
Fixes #18125
Fixes #18250

Author: smarter

compiler/src/dotty/tools/dotc/ast/Desugar.scala

@@ -381,11 +381,14 @@ object desugar {
     tree match
       case untpd.Block(stats, expr) =>
         val (untpdTypeVariables, otherStats) = stats.span {
-          case tdef @ untpd.TypeDef(name, _) => name.isVarPattern
+          case tdef @ untpd.TypeDef(name, _) => !tdef.isBackquoted && name.isVarPattern
           case _ => false
         }
+        val untpdCaseTypeVariables = untpdTypeVariables.asInstanceOf[List[untpd.TypeDef]].map {
+          tdef => tdef.withMods(tdef.mods | Case)
+        }
         val pattern = if otherStats.isEmpty then expr else untpd.cpy.Block(tree)(otherStats, expr)
-        (untpdTypeVariables.asInstanceOf[List[untpd.TypeDef]], pattern)
+        (untpdCaseTypeVariables, pattern)
       case _ =>
         (Nil, tree)
 

compiler/src/dotty/tools/dotc/quoted/QuotePatterns.scala

@@ -15,6 +15,7 @@ import dotty.tools.dotc.core.NameKinds.PatMatGivenVarName
 import dotty.tools.dotc.core.Names.*
 import dotty.tools.dotc.core.StdNames.*
 import dotty.tools.dotc.core.Symbols.*
+import dotty.tools.dotc.core.TypeOps.*
 import dotty.tools.dotc.core.Types.*
 import dotty.tools.dotc.reporting.IllegalVariableInPatternAlternative
 import dotty.tools.dotc.transform.SymUtils._
@@ -24,6 +25,33 @@ import scala.collection.mutable
 object QuotePatterns:
   import tpd._
 
+  /** Check for restricted patterns */
+  def checkPattern(quotePattern: QuotePattern)(using Context): Unit = new tpd.TreeTraverser {
+    def traverse(tree: Tree)(using Context): Unit = tree match {
+      case _: SplicePattern =>
+      case tdef: TypeDef if tdef.symbol.isClass =>
+        val kind = if tdef.symbol.is(Module) then "objects" else "classes"
+        report.error(em"Implementation restriction: cannot match $kind", tree.srcPos)
+      case tree: NamedDefTree =>
+        if tree.name.is(NameKinds.WildcardParamName) then
+          report.warning(
+            "Use of `_` for lambda in quoted pattern. Use explicit lambda instead or use `$_` to match any term.",
+            tree.srcPos)
+        if tree.name.isTermName && !tree.nameSpan.isSynthetic && tree.name != nme.ANON_FUN && tree.name.startsWith("$") then
+          report.error("Names cannot start with $ quote pattern", tree.namePos)
+        traverseChildren(tree)
+      case _: Match =>
+        report.error("Implementation restriction: cannot match `match` expressions", tree.srcPos)
+      case _: Try =>
+        report.error("Implementation restriction: cannot match `try` expressions", tree.srcPos)
+      case _: Return =>
+        report.error("Implementation restriction: cannot match `return` statements", tree.srcPos)
+      case _ =>
+        traverseChildren(tree)
+    }
+
+  }.traverse(quotePattern.body)
+
   /** Encode the quote pattern into an `unapply` that the pattern matcher can handle.
    *
    *  A quote pattern

compiler/src/dotty/tools/dotc/typer/QuotesAndSplices.scala

@@ -0,0 +1,7 @@
+-- [E007] Type Mismatch Error: tests/neg-macros/i16522.scala:10:45 -----------------------------------------------------
+10 |      case '{HCons($h1: hd1, HCons($h2: hd2, $_ : tl))} => '{$h1.toString ++ $h2.toString} // error
+   |                                             ^^^^^^^
+   |                                             Found:    tl
+   |                                             Required: HList
+   |
+   | longer explanation available when compiling with `-explain`

tests/neg-macros/i16522.check

@@ -0,0 +1,16 @@
+  import scala.quoted.*
+
+  sealed trait HList
+  case class HCons[+HD, TL <: HList](hd: HD, tl: TL) extends HList
+  case object HNil extends HList
+
+  def showFirstTwoImpl(e: Expr[HList])(using Quotes): Expr[String] = {
+    e match {
+      case '{HCons($h1, HCons($h2, $_))} => '{$h1.toString ++ $h2.toString}
+      case '{HCons($h1: hd1, HCons($h2: hd2, $_ : tl))} => '{$h1.toString ++ $h2.toString} // error
+      case '{HCons[hd, HCons[sd, tl]]($h1, HCons($h2, $_))} => '{$h1.toString ++ $h2.toString}
+      case _ => '{""}
+    }
+  }
+
+  transparent inline def showFirstTwo(inline xs: HList) = ${ showFirstTwoImpl('xs) }

tests/neg-macros/i16522.scala

@@ -5,7 +5,7 @@ import scala.quoted.*
 inline def mcr(x: => Any): Any = ${mcrImpl('x)}
 
 def mcrImpl(body: Expr[Any])(using ctx: Quotes): Expr[Any] = {
-  val '{$x: $t} = body // error
+  val '{$x: $t} = body // error // error
   '{
     val tmp: $t = $x.asInstanceOf[$t] // error // error
     println(tmp)

tests/neg-macros/i6997b.scala

@@ -0,0 +1,10 @@
+import scala.quoted.*
+
+object Main {
+  def foo(a: Expr[Any])(using Quotes) = {
+    a match {
+      case '{ ($x: Set[t]).toSet } =>
+      case _ =>
+    }
+  }
+}

tests/pos-macros/i14708.scala

@@ -0,0 +1,16 @@
+  import scala.quoted.*
+
+  sealed trait HList
+  case class HCons[+HD, TL <: HList](hd: HD, tl: TL) extends HList
+  case object HNil extends HList
+
+  def showFirstTwoImpl(e: Expr[HList])(using Quotes): Expr[String] = {
+    e match {
+      case '{HCons($h1, HCons($h2, $_))} => '{$h1.toString ++ $h2.toString}
+      case '{type tl <: HList; HCons($h1: hd1, HCons($h2: hd2, $_ : tl))} => '{$h1.toString ++ $h2.toString} // error
+      case '{HCons[hd, HCons[sd, tl]]($h1, HCons($h2, $_))} => '{$h1.toString ++ $h2.toString}
+      case _ => '{""}
+    }
+  }
+
+  transparent inline def showFirstTwo(inline xs: HList) = ${ showFirstTwoImpl('xs) }

tests/pos-macros/i16522.scala

@@ -0,0 +1,10 @@
+import scala.quoted.*
+
+final class Foo[T](ns: T)
+
+def foo(using Quotes)(x: Expr[Any]): Unit =
+  x match
+    case '{ new Foo($y: b) } =>
+    case '{ new Foo($y: List[b]) } =>
+    case '{ type b; new Foo($y: b) } =>
+

tests/pos-macros/i18125.scala

@@ -0,0 +1,23 @@
+package oolong.phobos
+
+import scala.quoted.*
+import scala.compiletime.*
+import scala.annotation.StaticAnnotation
+
+final class xmlns[T](ns: T) extends StaticAnnotation
+trait Namespace[T]{
+    val getNamespace: String
+}
+
+object common{
+  private def extractFeildNamespace(using Quotes)(
+      fieldAnnotations: List[Expr[Any]],
+  ): Expr[Option[String]] = {
+    import quotes.reflect.*
+
+    fieldAnnotations.collect { case '{ xmlns($namespace: b) } =>
+      '{ Some(summonInline[Namespace[b]].getNamespace) }
+    }
+    ???
+  }
+}