Merge pull request #2821 from mikla/implicit-function-error-message

#1589 Move "implicit function type needs non-empty parameter list" error to a new errors format.

Author: felixmulder

compiler/src/dotty/tools/dotc/reporting/diagnostic/ErrorMessageID.java

@@ -92,6 +92,7 @@ public enum ErrorMessageID {
     SuperCallsNotAllowedInlineID,
     ModifiersNotAllowedID,
     WildcardOnTypeArgumentNotAllowedOnNewID,
+    ImplicitFunctionTypeNeedsNonEmptyParameterListID,
     ;
 
     public int errorNumber() {

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

@@ -1668,4 +1668,23 @@ object messages {
         """
     }
   }
+
+  case class ImplicitFunctionTypeNeedsNonEmptyParameterList()(implicit ctx: Context)
+    extends Message(ImplicitFunctionTypeNeedsNonEmptyParameterListID) {
+    val kind = "Syntax"
+    val msg = "implicit function type needs non-empty parameter list"
+    val explanation = {
+      val code1 = "type Transactional[T] = implicit Transaction => T"
+      val code2 = "val cl: implicit A => B"
+      hl"""It is not allowed to leave implicit function parameter list empty.
+         |Possible ways to define implicit function type:
+         |
+         |$code1
+         |
+         |or
+         |
+         |$code2""".stripMargin
+    }
+  }
+
 }

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -690,7 +690,7 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
       val isImplicit = tree match {
         case _: untpd.ImplicitFunction =>
           if (args.length == 0) {
-            ctx.error(i"implicit function type needs non-empty parameter list", tree.pos)
+            ctx.error(ImplicitFunctionTypeNeedsNonEmptyParameterList(), tree.pos)
             false
           }
           else true

compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala

@@ -877,4 +877,20 @@ class ErrorMessagesTests extends ErrorMessagesTest {
 
         assertEquals(err, WildcardOnTypeArgumentNotAllowedOnNew())
       }
+
+  @Test def implicitFunctionTypeNeedsNonEmptyParameterList =
+    checkMessagesAfter("refchecks") {
+      """abstract class Foo {
+        |  type Contextual[T] = implicit () => T
+        |  val x: implicit () => Int
+        |}""".stripMargin
+    }
+      .expect { (ictx, messages) =>
+        implicit val ctx: Context = ictx
+        val defn = ictx.definitions
+
+        assertMessageCount(2, messages)
+        messages.foreach(assertEquals(_, ImplicitFunctionTypeNeedsNonEmptyParameterList()))
+      }
+
 }