Polishings

Author: odersky

compiler/src/dotty/tools/dotc/Run.scala

@@ -214,7 +214,6 @@ class Run(comp: Compiler, ictx: Context) extends ImplicitRunInfo with Constraint
       }
       process()(runContext.fresh.setCompilationUnit(unit))
     }
-    else None
 
   private sealed trait PrintedTree
   private /*final*/ case class SomePrintedTree(phase: String, tree: String) extends PrintedTree

compiler/src/dotty/tools/dotc/ast/tpd.scala

@@ -873,7 +873,7 @@ object tpd extends Trees.Instance[Type] with TypedTreeInfo {
     def tpes: List[Type] = xs map (_.tpe)
   }
 
-  /** A trait for loaders that compute trees. Common base trait for DottyUnpickler and SymbolLoader */
+  /** A trait for loaders that compute trees. Currently implemented just by DottyUnpickler. */
   trait TreeProvider {
     protected def computeTrees(implicit ctx: Context): List[Tree]
 

compiler/src/dotty/tools/dotc/config/Config.scala

@@ -160,7 +160,7 @@ object Config {
   final val showCompletions = false
 
   /** If set, enables tracing */
-  final val tracingEnabled = true
+  final val tracingEnabled = false
 
   /** Initial capacity of uniques HashMap.
    *  Note: This MUST BE a power of two to work with util.HashSet

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -1134,7 +1134,7 @@ object SymDenotations {
     /** The primary constructor of a class or trait, NoSymbol if not applicable. */
     def primaryConstructor(implicit ctx: Context): Symbol = NoSymbol
 
-    /** The current declaration of this symbol's class owner that has the same name
+    /** The current declaration in this symbol's class owner that has the same name
      *  as this one, and, if there are several, also has the same signature.
      */
     def currentSymbol(implicit ctx: Context): Symbol = {

compiler/src/dotty/tools/dotc/core/Symbols.scala

@@ -634,8 +634,9 @@ object Symbols {
       */
     def tree(implicit ctx: Context): Tree = treeContaining("")
 
-    /** Same as `tree` but load only Tasty tree if the name table of the unpickler
-     *  contains `id`.
+    /** Same as `tree` but load tree only if `id == ""` or the tree might contain `id`.
+     *  For Tasty trees this means consulting whether the name table defines `id`.
+     *  For already loaded trees, we maintain the referenced ids in an attachment.
      */
     def treeContaining(id: String)(implicit ctx: Context): Tree = denot.infoOrCompleter match {
       case _: NoCompleter =>

compiler/src/dotty/tools/dotc/interactive/InteractiveDriver.scala

@@ -71,7 +71,6 @@ class InteractiveDriver(settings: List[String]) extends Driver {
         clsd.ensureCompleted()
         SourceTree.fromSymbol(clsd.symbol.asClass, id)
       case _ =>
-        //sys.error(s"class not found: $className")
         None
     }
   }