Adress some review comments and other tweaks

Author: odersky

compiler/src/dotty/tools/dotc/transform/DropBreaks.scala

@@ -24,7 +24,7 @@ object DropBreaks:
   class LabelUsage(val goto: TermSymbol, val enclMeth: Symbol):
     /** The number of references to associated label that come from labeled returns */
     var returnRefs: Int = 0
-    /** The number of other references to assocated label */
+    /** The number of other references to associated label */
     var otherRefs: Int = 0
 
   private val LabelUsages = new Property.Key[Map[Symbol, LabelUsage]]
@@ -167,7 +167,7 @@ class DropBreaks extends MiniPhase, RecordStackChange:
   override def prepareForApply(tree: Apply)(using Context): Context = tree match
     case Break(_, _) => ctx
     case _ => stackChange
-    
+
   // other stack changing operations are handled in RecordStackChange
 
   /** If `tree` is a BreakBoundary, transform it as follows:
@@ -221,8 +221,4 @@ class DropBreaks extends MiniPhase, RecordStackChange:
       uses.otherRefs += 1
     tree
 
-  //override def transformReturn(tree: Return)(using Context): Tree =
-  //  if !tree.from.isEmpty && tree.expr.tpe.isExactlyNothing then tree.expr
-  //  else tree
-
 end DropBreaks

library/src/scala/util/break.scala

@@ -8,13 +8,13 @@ object break:
   /** Abort current computation and instead return `value` as the value of
    *  the enclosing `boundary` call that created `label`.
    */
-  def apply[T](value: T)(using l: boundary.Label[T]): Nothing =
-    l.break(value)
+  def apply[T](value: T)(using label: boundary.Label[T]): Nothing =
+    label.break(value)
 
   /** Abort current computation and instead continue after the `boundary` call that
    *  created `label`.
    */
-  def apply()(using l: boundary.Label[Unit]): Nothing =
-    apply(())
+  def apply()(using label: boundary.Label[Unit]): Nothing =
+    label.break(())
 
-end break
+end break

tests/run/errorhandling/kostas.scala

@@ -1,5 +1,5 @@
 package optionMockup:
-  import dotty.util.boundary
+  import scala.util.boundary
   object optional:
     transparent inline def apply[T](inline body: boundary.Label[None.type] ?=> T): Option[T] =
       boundary(Some(body))