Delete redundantly warning for list options

Author: som-snytt

compiler/src/dotty/tools/dotc/config/Settings.scala

@@ -257,11 +257,8 @@ object Settings:
         // check whether a value was previously set
         def checkRedundant(actual: List[String]) =
           if changed then
-            var dangers: List[String] = Nil
             val current = valueIn(sstate).asInstanceOf[List[String]]
-            for value <- split if current.contains(value) do
-              dangers :+= s"Setting $name set to $value redundantly"
-            dangers.foldLeft(update(current ++ actual, arg, args))((sum, w) => sum.warn(w))
+            update(current ++ actual, arg, args)
           else
             update(actual, arg, args)
         choices match

compiler/test/dotty/tools/dotc/config/ScalaSettingsTests.scala

@@ -58,7 +58,7 @@ class ScalaSettingsTests:
     assertTrue("Has the feature", set.contains("implicitConversions"))
     assertTrue("Has the feature", set.contains("dynamics"))
 
-  @Test def `Warn if multistring element is supplied multiply`: Unit =
+  @Test def `Don't warn if multistring element is supplied multiply`: Unit =
     class SUT extends SettingGroup:
       val language: Setting[List[String]] = MultiStringSetting(RootSetting, "language", "feature", "Enable one or more language features.")
     val sut  = SUT()
@@ -67,7 +67,7 @@ class ScalaSettingsTests:
     val res  = sut.processArguments(sumy, processAll = true, skipped = Nil)
     val set  = sut.language.valueIn(res.sstate)
     assertEquals(3, args.length)
-    assertEquals("Must warn", 1, res.warnings.length)
+    assertTrue("Mustn't warn", res.warnings.isEmpty)
     assertTrue("No errors!", res.errors.isEmpty)
     assertTrue("Has the feature", set.contains("implicitConversions"))
     assertTrue("Has the feature", set.contains("dynamics"))

tests/neg/no-patches.check

@@ -1,4 +1,3 @@
-Flag -Yno-stdlib-patches set repeatedly
 -- Error: tests/neg/no-patches.scala:3:23 ------------------------------------------------------------------------------
 3 |val _ = scala.language.`3.4` // error: we do not patch `scala.language`
   |        ^^^^^^^^^^^^^^^^^^^^