refactor names and remove dead code

Author: bishabosha

compiler/src/dotty/tools/dotc/core/Definitions.scala

@@ -750,7 +750,6 @@ class Definitions {
   @tu lazy val RefiningAnnotationClass: ClassSymbol = ctx.requiredClass("scala.annotation.RefiningAnnotation")
 
   // Annotation classes
-  @tu lazy val ScalaAnnotationInternal: ClassSymbol = ctx.requiredClass("scala.annotation.internal")
   @tu lazy val AliasAnnot: ClassSymbol = ctx.requiredClass("scala.annotation.internal.Alias")
   @tu lazy val AnnotationDefaultAnnot: ClassSymbol = ctx.requiredClass("scala.annotation.internal.AnnotationDefault")
   @tu lazy val BodyAnnot: ClassSymbol = ctx.requiredClass("scala.annotation.internal.Body")

compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala

@@ -53,7 +53,7 @@ class ExtractSemanticDB extends Phase with
     /** The index of a local symbol */
     private val locals = mutable.HashMap[Symbol, Int]()
 
-    /** The bodies of synthetic localså */
+    /** The bodies of synthetic locals */
     private val localBodies = mutable.HashMap[Symbol, Tree]()
 
     /** The local symbol(s) starting at given offset */

compiler/src/dotty/tools/dotc/semanticdb/Scala3.scala

@@ -142,7 +142,7 @@ object Scala3 with
 
   end LocalSymbol
 
-  private inline def (char: Char) `is/.#])` = (char: @switch) match
+  private inline def (char: Char) isGlobalTerminal = (char: @switch) match
     case '/' | '.' | '#' | ']' | ')' => true
     case _                           => false
 
@@ -152,8 +152,8 @@ object Scala3 with
     def isRootPackage: Boolean = RootPackage == symbol
     def isEmptyPackage: Boolean = EmptyPackage == symbol
 
-    def isGlobal: Boolean = !symbol.isEmpty && !symbol.isMulti && symbol.last.`is/.#])`
-    def isLocal: Boolean = !symbol.isEmpty && !symbol.isMulti && !symbol.last.`is/.#])`
+    def isGlobal: Boolean = !symbol.isEmpty && !symbol.isMulti && symbol.last.isGlobalTerminal
+    def isLocal: Boolean = !symbol.isEmpty && !symbol.isMulti && !symbol.last.isGlobalTerminal
     def isMulti: Boolean = symbol startsWith ";"
 
     def isConstructor: Boolean = ctor matches symbol