MissingIdent: take a Name instead of a String

Let the class itself worry about how to display that name, and means we
can compare that name in `saysNotFound` without having to convert it to
a String.

Author: smarter

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

@@ -279,7 +279,7 @@ object messages {
     }
   }
 
-  case class MissingIdent(tree: untpd.Ident, treeKind: String, name: String)(implicit ctx: Context)
+  case class MissingIdent(tree: untpd.Ident, treeKind: String, name: Name)(implicit ctx: Context)
   extends Message(MissingIdentID) {
     val kind: String = "Unbound Identifier"
     val msg: String = em"Not found: $treeKind$name"

compiler/src/dotty/tools/dotc/typer/Applications.scala

@@ -1068,7 +1068,7 @@ trait Applications extends Compatibility {
           case NotAMember(_, name, _, _) =>
             memberName.isEmpty || name == memberName
           case MissingIdent(_, _, name) =>
-            memberName.isEmpty || name == memberName.toString
+            memberName.isEmpty || name == memberName
           case _ => false
       case _ => false
 

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -451,7 +451,7 @@ class Typer extends Namer
         // of a this(...) constructor call
         errorType(ex"$tree is not accessible from constructor arguments", tree.sourcePos)
       else
-        errorType(new MissingIdent(tree, kind, name.show), tree.sourcePos)
+        errorType(new MissingIdent(tree, kind, name), tree.sourcePos)
 
     val tree1 = ownType match {
       case ownType: NamedType =>