Merge pull request #2742 from dotty-staging/fix-#2741

Fix #2741: Handle wildcard types in unions and intersections.

Author: felixmulder

compiler/src/dotty/tools/dotc/core/Types.scala

@@ -1423,8 +1423,11 @@ object Types {
   /** A marker trait for types that can be types of values or prototypes of value types */
   trait ValueTypeOrProto extends TermType
 
+  /** A marker trait for types that can be types of values or wildcards */
+  trait ValueTypeOrWildcard extends TermType
+
   /** A marker trait for types that can be types of values or that are higher-kinded  */
-  trait ValueType extends ValueTypeOrProto
+  trait ValueType extends ValueTypeOrProto with ValueTypeOrWildcard
 
   /** A marker trait for types that are guaranteed to contain only a
    *  single non-null value (they might contain null in addition).
@@ -2317,7 +2320,8 @@ object Types {
 
   object AndType {
     def apply(tp1: Type, tp2: Type)(implicit ctx: Context): AndType = {
-      assert(tp1.isValueType && tp2.isValueType, i"$tp1 & $tp2 / " + s"$tp1 & $tp2")
+      assert(tp1.isInstanceOf[ValueTypeOrWildcard] &&
+             tp2.isInstanceOf[ValueTypeOrWildcard], i"$tp1 & $tp2 / " + s"$tp1 & $tp2")
       unchecked(tp1, tp2)
     }
 
@@ -2340,7 +2344,8 @@ object Types {
 
   abstract case class OrType(tp1: Type, tp2: Type) extends CachedGroundType with AndOrType {
 
-    assert(tp1.isInstanceOf[ValueType] && tp2.isInstanceOf[ValueType])
+    assert(tp1.isInstanceOf[ValueTypeOrWildcard] &&
+           tp2.isInstanceOf[ValueTypeOrWildcard], s"$tp1 $tp2")
     def isAnd = false
 
     private[this] var myJoin: Type = _
@@ -2375,7 +2380,8 @@ object Types {
       unique(new CachedOrType(tp1, tp2))
     }
     def make(tp1: Type, tp2: Type)(implicit ctx: Context): Type =
-      if (tp1 eq tp2) tp1 else apply(tp1, tp2)
+      if (tp1 eq tp2) tp1
+      else apply(tp1, tp2)
   }
 
   // ----- ExprType and LambdaTypes -----------------------------------
@@ -3506,7 +3512,7 @@ object Types {
   object TryDynamicCallType extends FlexType
 
   /** Wildcard type, possibly with bounds */
-  abstract case class WildcardType(optBounds: Type) extends CachedGroundType with TermType {
+  abstract case class WildcardType(optBounds: Type) extends CachedGroundType with ValueTypeOrWildcard {
     def derivedWildcardType(optBounds: Type)(implicit ctx: Context) =
       if (optBounds eq this.optBounds) this
       else if (!optBounds.exists) WildcardType

tests/pos/i2741.scala

@@ -0,0 +1,16 @@
+object Result {
+  type ResultF[F] = F | Errors
+  type ResultF2[F] = F & Errors
+
+  case class Errors(msgs: Seq[String])
+
+  implicit class ResultFunctions[A](val res: ResultF[A]) extends AnyVal {
+    def map[B](f: A => B): ResultF[B] = res match {
+      case errs: Errors => errs
+      case x: A => f(x)
+    }
+  }
+  implicit class ResultFunctions2[A](val res: ResultF2[A]) extends AnyVal {
+    def map[B](f: A => B): ResultF[B] = ???
+  }
+}