Commit 0fbf014
committed
lookupRefined: check for AliasingBounds instead of TypeBounds with equal bounds
It turns out that the problematic cases fixed in the previous commit only occurs
because we create type aliases with info of type MatchAlias instead of TypeAlias
if their rhs is an applied match type (Namer#TypeDefCompleter#typeSig calls
`toBounds` on the rhs which does `if (self.isMatch) MatchAlias(self)`).
I'm not sure if there is a good reason for that (and if so, do we need to be
careful to avoid loops when dealiasing MatchAlias? `lookupRefined` doesn't
actually loop on the alias but maybe it should?) or if we should change the
logic in Namer to return a TypeAlias instead.1 parent be9c8be commit 0fbf014
1 file changed
+4
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1548 | 1548 | | |
1549 | 1549 | | |
1550 | 1550 | | |
1551 | | - | |
1552 | | - | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
1553 | 1555 | | |
1554 | 1556 | | |
1555 | 1557 | | |
| |||
0 commit comments