Build fixes; license; groupId = org.scala-lang.modules

The license is a standard 3-clause BSD license.

We're publishing modules under org.scala-lang.modules.
This signals they are "just another Scala library":
  - cross-versioned (cross-versioning under org.scala-lang confuses sbt)
  - backward binary compatible (but not forward like the core)

Compile under Optimize/Deprecation/Features/Lint.

Fix deprecation errors:
Don't call log in ValidatingMarkupHandler, CachedFileStorage anymore,
as that generates deprecation messages, and apparently we should use
a debugger to debug.

Author: adriaanm

LICENSE.md

@@ -1,38 +1,47 @@
-organization := "org.scala-lang"
+organization := "org.scala-lang.modules"
 
 name := "scala-xml"
 
 version := "1.0-RC2"
 
-scalaVersion := "2.11.0-M4"
-
-scalaBinaryVersion := scalaVersion.value
 
+// dependencies:
 libraryDependencies += "org.apache.ant"                 % "ant"            % "1.8.4"
 
 libraryDependencies += "com.googlecode.java-diff-utils" % "diffutils"      % "1.3.0"
 
-libraryDependencies += "org.scala-lang"                 % "scala-xml"      % "2.11.0-M4"
-
 libraryDependencies += "org.scala-lang"                 % "scalap"         % "2.11.0-M4"
 
 libraryDependencies += "org.scalacheck"                %% "scalacheck"     % "1.10.1"
 
 libraryDependencies += "org.scala-sbt"                  % "test-interface" % "1.0"
 
 
-// xml.properties
+// standard stuff follows:
+scalaVersion := "2.11.0-M4"
+
+// NOTE: not necessarily equal to scalaVersion
+// (e.g., during PR validation, we override scalaVersion to validate,
+// but don't rebuild scalacheck, so we don't want to rewire that dependency)
+scalaBinaryVersion := "2.11.0-M4"
+
+// don't use for doc scope, scaladoc warnings are not to be reckoned with
+scalacOptions in compile ++= Seq("-optimize", "-Xfatal-warnings", "-feature", "-deprecation", "-unchecked", "-Xlint")
+
+
+// Generate $name.properties to store our version as well as the scala version used to build
 resourceGenerators in Compile <+= Def.task {
   val props = new java.util.Properties
   props.put("version.number", version.value)
   props.put("scala.version.number", scalaVersion.value)
-  val file = (resourceManaged in Compile).value / "xml.properties"
+  props.put("scala.binary.version.number", scalaBinaryVersion.value)
+  val file = (resourceManaged in Compile).value / s"${name.value}.properties"
   IO.write(props, null, file)
   Seq(file)
 }
 
 mappings in (Compile, packageBin) += {
-   (baseDirectory.value / "xml.properties") -> "xml.properties"
+   (baseDirectory.value / s"${name.value}.properties") -> s"${name.value}.properties"
 }
 
 
@@ -56,24 +65,23 @@ pomExtra := (
   <inceptionYear>2002</inceptionYear>
   <licenses>
     <license>
-      <name>BSD-like</name>
-      <url>http://www.scala-lang.org/downloads/license.html
-      </url>
-      <distribution>repo</distribution>
+        <distribution>repo</distribution>
+        <name>BSD 3-Clause</name>
+        <url>https://github.com/scala/{name.value}/blob/master/LICENSE.md</url>
     </license>
-  </licenses>
+   </licenses>
   <scm>
-    <connection>scm:git:git://github.com/scala/scala-xml.git</connection>
-    <url>https://github.com/scala/scala-xml</url>
+    <connection>scm:git:git://github.com/scala/{name.value}.git</connection>
+    <url>https://github.com/scala/{name.value}</url>
   </scm>
   <issueManagement>
     <system>JIRA</system>
     <url>https://issues.scala-lang.org/</url>
   </issueManagement>
   <developers>
     <developer>
-      <id>lamp</id>
-      <name>EPFL LAMP</name>
+      <id>epfl</id>
+      <name>EPFL</name>
     </developer>
     <developer>
       <id>Typesafe</id>
@@ -83,11 +91,11 @@ pomExtra := (
 )
 
 // for testing with partest
-libraryDependencies += "org.scala-lang" %% "scala-partest-interface" % "0.1" % "test"
+libraryDependencies += "org.scala-lang.modules" %% "scala-partest-interface" % "0.2" % "test"
 
 // the actual partest the interface calls into -- must be binary version close enough to ours
 // so that it can link to the compiler/lib we're using (testing)
-libraryDependencies += "org.scala-lang" %% "scala-partest" % "1.0-RC1" % "test"
+libraryDependencies += "org.scala-lang.modules" %% "scala-partest" % "1.0-RC2" % "test"
 
 fork in Test := true
 
@@ -110,4 +118,4 @@ definedTests in Test += (
 // TODO: mima
 // import com.typesafe.tools.mima.plugin.MimaPlugin.mimaDefaultSettings
 // import com.typesafe.tools.mima.plugin.MimaKeys.previousArtifact
-// previousArtifact := Some("org.scala-lang" % "partest_2.11.0-M4" % "1.0")
+// previousArtifact := Some(organization.value %% name.value % binaryReferenceVersion.value)

README.md

@@ -39,6 +39,8 @@ object Elem {
   }
 
   import scala.sys.process._
+  import scala.language.implicitConversions
+
   /**
    * Implicitly convert a [[scala.xml.Elem]] into a
    * [[scala.sys.process.ProcessBuilder]]. This is done by obtaining the text