Merge pull request #130 from MasseGuillaume/apply-to

Extend the .to(CC) refactor to f(cc.to)

Author: julienrf

scalafix/input/src/main/scala/fix/ReplaceToSrc.scala

@@ -14,4 +14,7 @@ object ReplaceToSrc {
 
   def m2(xs: List[Int]): Iterable[Int] =
     xs.to
+
+  def f(xs: List[Int]): Unit = ()
+  f(Set(1).to)
 }

scalafix/output/src/main/scala/fix/ReplaceToSrc.scala

@@ -15,4 +15,7 @@ object ReplaceToSrc {
 
   def m2(xs: List[Int]): Iterable[Int] =
     xs.to(scala.collection.immutable.IndexedSeq)
+
+  def f(xs: List[Int]): Unit = ()
+  f(Set(1).to(scala.collection.immutable.List))
 }

scalafix/rules/src/main/scala/fix/Stable212Base.scala

@@ -273,22 +273,16 @@ trait Stable212Base extends CrossCompatibility { self: SemanticRule =>
           }.asPatch
 
         case t @ Term.Select(_, to @ toTpe(n: Name)) if !handledTo.contains(n) =>
-          // we only want f.to, not f.to(X)
-          val applied =
-            t.parent match {
-              case Some(_:Term.Apply) =>  true
-              case _ => false
+          val synth = ctx.index.synthetics.find(_.position.end == to.pos.end)
+          synth.map{ s =>
+            s.text.parse[Term].get match {
+              // we only want f.to, not f.to(X)
+              case Term.Apply(_, List(toCol)) =>
+                val col = extractCollection(toCol)
+                ctx.addRight(to, "(" + col + ")")
+              case _ => Patch.empty
             }
-
-          if (!applied) {
-            val synth = ctx.index.synthetics.find(_.position.end == to.pos.end)
-            synth.map{ s =>
-              val res = s.text.parse[Term].get
-              val Term.Apply(_, List(toCol)) = res
-              val col = extractCollection(toCol)
-              ctx.addRight(to, "(" + col + ")")
-            }.getOrElse(Patch.empty)
-          } else Patch.empty
+          }.getOrElse(Patch.empty)
 
       }.asPatch