Fix a bunch of style issues discovered by Scalastyle.

Author: sjrd

js-envs/src/test/scala/org/scalajs/jsenv/test/AsyncTests.scala

@@ -28,7 +28,7 @@ trait AsyncTests {
   }
 
   @Test
-  def futureTest = {
+  def futureTest: Unit = {
     val runner = asyncRunner("")
     val fut = runner.start()
 
@@ -38,7 +38,7 @@ trait AsyncTests {
   }
 
   @Test
-  def stopAfterTerminatedTest = {
+  def stopAfterTerminatedTest: Unit = {
     val runner = asyncRunner("")
     val fut = runner.start()
 

js-envs/src/test/scala/org/scalajs/jsenv/test/ComTests.scala

@@ -36,7 +36,7 @@ trait ComTests extends AsyncTests {
   }
 
   @Test
-  def comCloseJVMTest = {
+  def comCloseJVMTest: Unit = {
     val com = comRunner(s"""
       scalajsCom.init(function(msg) { scalajsCom.send("received: " + msg); });
       scalajsCom.send("Hello World");
@@ -57,7 +57,7 @@ trait ComTests extends AsyncTests {
     com.stop() // should do nothing, and not fail
   }
 
-  def comCloseJSTestCommon(timeout: Long) = {
+  def comCloseJSTestCommon(timeout: Long): Unit = {
     val com = comRunner(s"""
       scalajsCom.init(function(msg) {});
       for (var i = 0; i < 10; ++i)
@@ -82,13 +82,13 @@ trait ComTests extends AsyncTests {
   }
 
   @Test
-  def comCloseJSTest = comCloseJSTestCommon(0)
+  def comCloseJSTest: Unit = comCloseJSTestCommon(0)
 
   @Test
-  def comCloseJSTestDelayed = comCloseJSTestCommon(1000)
+  def comCloseJSTestDelayed: Unit = comCloseJSTestCommon(1000)
 
   @Test
-  def doubleCloseTest = {
+  def doubleCloseTest: Unit = {
     val n = 10
     val com = pingPongRunner(n)
 
@@ -104,7 +104,7 @@ trait ComTests extends AsyncTests {
   }
 
   @Test
-  def multiEnvTest = {
+  def multiEnvTest: Unit = {
     val n = 10
     val envs = List.fill(5)(pingPongRunner(10))
 
@@ -137,7 +137,7 @@ trait ComTests extends AsyncTests {
   }
 
   @Test
-  def largeMessageTest = {
+  def largeMessageTest: Unit = {
     // 1KB data
     val baseMsg = new String(Array.tabulate(512)(_.toChar))
     val baseLen = baseMsg.length
@@ -178,7 +178,7 @@ trait ComTests extends AsyncTests {
   }
 
   @Test
-  def highCharTest = { // #1536
+  def highCharTest: Unit = { // #1536
     val com = comRunner("""
       scalajsCom.init(scalajsCom.send);
     """)
@@ -195,7 +195,7 @@ trait ComTests extends AsyncTests {
   }
 
   @Test
-  def noInitTest = {
+  def noInitTest: Unit = {
     val com = comRunner("")
 
     com.start()
@@ -205,7 +205,7 @@ trait ComTests extends AsyncTests {
   }
 
   @Test
-  def stopTestCom = {
+  def stopTestCom: Unit = {
     val com = comRunner(s"""scalajsCom.init(function(msg) {});""")
 
     com.start()
@@ -227,7 +227,7 @@ trait ComTests extends AsyncTests {
   }
 
   @Test
-  def futureStopTest = {
+  def futureStopTest: Unit = {
     val com = comRunner(s"""scalajsCom.init(function(msg) {});""")
 
     val fut = com.start()

js-envs/src/test/scala/org/scalajs/jsenv/test/CustomInitFilesTest.scala

@@ -18,7 +18,7 @@ abstract class CustomInitFilesTest extends JSEnvTest {
   }
 
   @Test
-  def customInitFilesTest = {
+  def customInitFilesTest: Unit = {
     """
     customPrint("hello");
     """ hasOutput
@@ -28,13 +28,13 @@ abstract class CustomInitFilesTest extends JSEnvTest {
 }
 
 class NodeJSWithCustomInitFilesTest extends CustomInitFilesTest {
-  protected def newJSEnv = new NodeJSEnv {
+  protected def newJSEnv: NodeJSEnv = new NodeJSEnv {
     override def customInitFiles() = makeCustomInitFiles()
   }
 }
 
 class PhantomJSWithCustomInitFilesTest extends CustomInitFilesTest {
-  protected def newJSEnv = new PhantomJSEnv {
+  protected def newJSEnv: PhantomJSEnv = new PhantomJSEnv {
     override def customInitFiles() = makeCustomInitFiles()
   }
 }

js-envs/src/test/scala/org/scalajs/jsenv/test/NodeJSTest.scala

@@ -7,11 +7,11 @@ import org.junit.Assert._
 
 class NodeJSTest extends TimeoutComTests {
 
-  protected def newJSEnv = new NodeJSEnv
+  protected def newJSEnv: NodeJSEnv = new NodeJSEnv
 
   /** Node.js strips double percentage signs - #500 */
   @Test
-  def percentageTest = {
+  def percentageTest: Unit = {
     val counts = 1 to 15
     val argcs  = 1 to 3
     val strings = counts.map("%" * _)
@@ -35,7 +35,7 @@ class NodeJSTest extends TimeoutComTests {
 
   /** Node.js console.log hack didn't allow to log non-Strings - #561 */
   @Test
-  def nonStringTest = {
+  def nonStringTest: Unit = {
 
     """
     console.log(1);
@@ -53,7 +53,7 @@ class NodeJSTest extends TimeoutComTests {
   }
 
   @Test
-  def slowJSEnvTest = {
+  def slowJSEnvTest: Unit = {
     val com = comRunner("""
       setTimeout(function() {
         scalajsCom.init(function(msg) {

js-envs/src/test/scala/org/scalajs/jsenv/test/TimeoutComTests.scala

@@ -9,7 +9,7 @@ import scala.concurrent.duration._
 trait TimeoutComTests extends TimeoutTests with ComTests {
 
   @Test
-  def delayedInitTest = {
+  def delayedInitTest: Unit = {
 
     val com = comRunner(s"""
       setTimeout(function() {
@@ -35,7 +35,7 @@ trait TimeoutComTests extends TimeoutTests with ComTests {
   }
 
   @Test
-  def delayedReplyTest = {
+  def delayedReplyTest: Unit = {
 
     val com = comRunner(s"""
       scalajsCom.init(function(msg) {
@@ -58,7 +58,7 @@ trait TimeoutComTests extends TimeoutTests with ComTests {
   }
 
   @Test
-  def receiveTimeoutTest = {
+  def receiveTimeoutTest: Unit = {
 
     val com = comRunner(s"""
       scalajsCom.init(function(msg) {
@@ -85,7 +85,7 @@ trait TimeoutComTests extends TimeoutTests with ComTests {
   }
 
   @Test
-  def intervalSendTest = {
+  def intervalSendTest: Unit = {
 
     val com = comRunner(s"""
       scalajsCom.init(function(msg) {});
@@ -108,7 +108,7 @@ trait TimeoutComTests extends TimeoutTests with ComTests {
   }
 
   @Test
-  def noMessageTest = {
+  def noMessageTest: Unit = {
     val com = comRunner(s"""
       // Make sure JVM has already closed when we init
       setTimeout(scalajsCom.init, 1000, function(msg) {});
@@ -119,7 +119,7 @@ trait TimeoutComTests extends TimeoutTests with ComTests {
   }
 
   @Test
-  def stopTestTimeout = {
+  def stopTestTimeout: Unit = {
 
     val async = asyncRunner(s"""
       setInterval(function() {}, 0);
@@ -140,7 +140,7 @@ trait TimeoutComTests extends TimeoutTests with ComTests {
   }
 
   @Test
-  def doubleStopTest = {
+  def doubleStopTest: Unit = {
     val async = asyncRunner(s"""
       setInterval(function() {}, 0);
     """)

js-envs/src/test/scala/org/scalajs/jsenv/test/TimeoutTests.scala

@@ -8,7 +8,7 @@ import scala.concurrent.duration._
 trait TimeoutTests extends JSEnvTest {
 
   @Test
-  def basicTimeoutTest = {
+  def basicTimeoutTest: Unit = {
 
     val deadline = 300.millis.fromNow
 
@@ -29,7 +29,7 @@ trait TimeoutTests extends JSEnvTest {
   }
 
   @Test
-  def clearTimeoutTest = {
+  def clearTimeoutTest: Unit = {
 
     val deadline = 300.millis.fromNow
 
@@ -52,7 +52,7 @@ trait TimeoutTests extends JSEnvTest {
   }
 
   @Test
-  def timeoutArgTest = {
+  def timeoutArgTest: Unit = {
 
     val deadline = 300.millis.fromNow
 
@@ -73,7 +73,7 @@ trait TimeoutTests extends JSEnvTest {
   }
 
   @Test
-  def intervalTest = {
+  def intervalTest: Unit = {
 
     val deadline = 1.second.fromNow
 
@@ -109,7 +109,7 @@ trait TimeoutTests extends JSEnvTest {
   }
 
   @Test
-  def intervalSelfClearTest = {
+  def intervalSelfClearTest: Unit = {
 
     val deadline = 100.millis.fromNow