Fix scala-js/scala-js#3410: Add supportsExit to JSEnvSuiteConfig.

We also remove terminateVMJSCode. This is a source breaking
change. However, leaving withTerminateVMJSCode would not relieve any
burden of sub-projects as the Suite would fail anyways.

Author: gzm0

js-envs-test-kit/src/main/scala/org/scalajs/jsenv/test/ComTests.scala

@@ -38,10 +38,10 @@ private[test] class ComTests(config: JSEnvSuiteConfig) {
 
   @Test
   def jsExitsOnMessageTest: Unit = {
-    assumeTrue(config.terminateVMJSCode.isDefined)
+    assumeTrue(config.supportsExit)
 
-    val run = kit.start(s"""
-      scalajsCom.init(function(msg) { ${config.terminateVMJSCode.get}; });
+    val run = kit.start("""
+      scalajsCom.init(function(msg) { __ScalaJSEnv.exitFunction(0); });
       for (var i = 0; i < 10; ++i)
         scalajsCom.send("msg: " + i);
       """, RunConfig())

js-envs-test-kit/src/main/scala/org/scalajs/jsenv/test/JSEnvSuiteConfig.scala

@@ -26,23 +26,23 @@ import scala.concurrent.duration._
  */
 final class JSEnvSuiteConfig private (
     val jsEnv: JSEnv,
-    val terminateVMJSCode: Option[String],
+    val supportsExit: Boolean,
     val supportsCom: Boolean,
     val supportsTimeout: Boolean,
     val awaitTimeout: FiniteDuration,
     val description: String
 ) {
   private def this(jsEnv: JSEnv) = this(
       jsEnv = jsEnv,
-      terminateVMJSCode = None,
+      supportsExit = true,
       supportsCom = true,
       supportsTimeout = true,
       awaitTimeout = 1.minute,
       description = jsEnv.name
   )
 
-  def withTerminateVMJSCode(code: String): JSEnvSuiteConfig =
-    copy(terminateVMJSCode = Some(code))
+  def withSupportsExit(supportsExit: Boolean): JSEnvSuiteConfig =
+    copy(supportsExit = supportsExit)
 
   def withSupportsCom(supportsCom: Boolean): JSEnvSuiteConfig =
     copy(supportsCom = supportsCom)
@@ -56,12 +56,13 @@ final class JSEnvSuiteConfig private (
   def withDescription(description: String): JSEnvSuiteConfig =
     copy(description = description)
 
-  private def copy(terminateVMJSCode: Option[String] = terminateVMJSCode,
+  private def copy(
+      supportsExit: Boolean = supportsExit,
       supportsCom: Boolean = supportsCom,
       supportsTimeout: Boolean = supportsTimeout,
       awaitTimeout: FiniteDuration = awaitTimeout,
       description: String = description) = {
-    new JSEnvSuiteConfig(jsEnv, terminateVMJSCode, supportsCom,
+    new JSEnvSuiteConfig(jsEnv, supportsExit, supportsCom,
         supportsTimeout, awaitTimeout, description)
   }
 }

js-envs-test-kit/src/main/scala/org/scalajs/jsenv/test/RunTests.scala

@@ -44,9 +44,9 @@ private[test] class RunTests(config: JSEnvSuiteConfig, withCom: Boolean) {
 
   @Test
   def jsExitsTest: Unit = {
-    assumeTrue(config.terminateVMJSCode.isDefined)
+    assumeTrue(config.supportsExit)
 
-    val run = kit.start(config.terminateVMJSCode.get, RunConfig())
+    val run = kit.start("__ScalaJSEnv.exitFunction(0);", RunConfig())
     try {
       Await.result(run.future, config.awaitTimeout)
     } finally {

nodejs-env/src/test/scala/org/scalajs/jsenv/nodejs/NodeJSSuite.scala

@@ -5,7 +5,4 @@ import org.scalajs.jsenv.test._
 import org.junit.runner.RunWith
 
 @RunWith(classOf[JSEnvSuiteRunner])
-class NodeJSSuite extends JSEnvSuite(
-    JSEnvSuiteConfig(new NodeJSEnv)
-      .withTerminateVMJSCode("process.exit(0)")
-)
+class NodeJSSuite extends JSEnvSuite(JSEnvSuiteConfig(new NodeJSEnv))