Skip to content

Commit 1169011

Browse files
committed
[no-master] Remove @deprecatedNames that were introduced in 0.6.16.
It is not possible to cross-compile `@deprecatedName`s without warnings between Scala 2.12- and 2.13+, because: * In 2.12, they require symbol literals as arguments * In 2.13, symbol literals are deprecated Since they were deprecated more than two years ago, and are part of an API that is not used much anyway (JS envs), I believe it is fair to drop the source compatibility in this case.
1 parent 0d65d88 commit 1169011

File tree

3 files changed

+0
-8
lines changed

3 files changed

+0
-8
lines changed

js-envs/src/main/scala/org/scalajs/jsenv/ExternalJSEnv.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ import scala.concurrent.{Future, Promise}
2424
import scala.util.Try
2525

2626
abstract class ExternalJSEnv(
27-
@deprecatedName('additionalArgs)
2827
final protected val args: Seq[String],
29-
@deprecatedName('additionalEnv)
3028
final protected val env: Map[String, String])
3129
extends AsyncJSEnv {
3230

js-envs/src/main/scala/org/scalajs/jsenv/nodejs/AbstractNodeJSEnv.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,8 @@ import scala.concurrent.TimeoutException
2929
import scala.concurrent.duration._
3030

3131
abstract class AbstractNodeJSEnv(
32-
@deprecatedName('nodejsPath)
3332
protected val executable: String,
34-
@deprecatedName('addArgs)
3533
args: Seq[String],
36-
@deprecatedName('addEnv)
3734
env: Map[String, String],
3835
val sourceMap: Boolean)
3936
extends ExternalJSEnv(args, env) with ComJSEnv {

js-envs/src/main/scala/org/scalajs/jsenv/nodejs/NodeJSEnv.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,8 @@ class NodeJSEnv(config: NodeJSEnv.Config)
3030

3131
@deprecated("Use the overload with a NodeJSEnv.Config.", "0.6.18")
3232
def this(
33-
@deprecatedName('nodejsPath)
3433
executable: String = "node",
35-
@deprecatedName('addArgs)
3634
args: Seq[String] = Seq.empty,
37-
@deprecatedName('addEnv)
3835
env: Map[String, String] = Map.empty) = {
3936
this(NodeJSEnv.Config().withExecutable(executable).withArgs(args.toList).withEnv(env))
4037
}

0 commit comments

Comments
 (0)