IDB versions are 64-bit, gotta use Double

japgolly · japgolly · commit b4e6fa0a872d · 2021-10-21T17:25:52.000+11:00
diff --git a/api-reports/2_12.txt b/api-reports/2_12.txt
@@ -14020,9 +14020,9 @@ IDBDatabase[JC] var onversionchange: js.Function1[IDBVersionChangeEvent, _]
 IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
 IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
 IDBDatabase[JC] def transaction(storeNames: String | js.Array[String], mode: js.UndefOr[IDBTransactionMode]?, options: js.UndefOr[IDBTransactionOptions]?): IDBTransaction
-IDBDatabase[JC] def version: Int
+IDBDatabase[JC] def version: Double
 IDBDatabaseInfo[JT] val name: String
-IDBDatabaseInfo[JT] val version: Int
+IDBDatabaseInfo[JT] val version: Double
 IDBEnvironment[JT] def indexedDB: IDBFactory  (@deprecated in 1.2.0)
 IDBEvent[JC] def bubbles: Boolean
 IDBEvent[JC] def cancelBubble: Boolean
@@ -14047,7 +14047,7 @@ IDBEventTarget[JC] def result: A
 IDBFactory[JC] def cmp(first: IDBValue, second: IDBValue): Int
 IDBFactory[JC] def databases(): js.Promise[js.Array[IDBDatabaseInfo]]
 IDBFactory[JC] def deleteDatabase(name: String): IDBOpenDBRequest[Unit]
-IDBFactory[JC] def open(name: String, version: Int?): IDBOpenDBRequest[IDBDatabase]
+IDBFactory[JC] def open(name: String, version: Double?): IDBOpenDBRequest[IDBDatabase]
 IDBIndex[JC] def count(query: IDBKey | IDBKeyRange?): IDBRequest[S, Double]
 IDBIndex[JC] def get(key: IDBKey | IDBKeyRange): IDBRequest[S, IDBValue]
 IDBIndex[JC] def getAll(query: js.UndefOr[IDBKeyRange | IDBKey]?, count: js.UndefOr[Double]?): IDBRequest[S, js.Array[IDBValue]]
@@ -14150,22 +14150,22 @@ IDBVersionChangeEvent[JC] def currentTarget: EventTarget
 IDBVersionChangeEvent[JC] def defaultPrevented: Boolean
 IDBVersionChangeEvent[JC] def eventPhase: Int
 IDBVersionChangeEvent[JC] def isTrusted: Boolean
-IDBVersionChangeEvent[JC] def newVersion: Integer
-IDBVersionChangeEvent[JC] def oldVersion: Int
+IDBVersionChangeEvent[JC] def newVersion: java.lang.Double
+IDBVersionChangeEvent[JC] def oldVersion: Double
 IDBVersionChangeEvent[JC] def preventDefault(): Unit
 IDBVersionChangeEvent[JC] def stopImmediatePropagation(): Unit
 IDBVersionChangeEvent[JC] def stopPropagation(): Unit
 IDBVersionChangeEvent[JC] def target: EventTarget
 IDBVersionChangeEvent[JC] override def target: IDBEventTarget[A]
 IDBVersionChangeEvent[JC] def timeStamp: Double
 IDBVersionChangeEvent[JC] def `type`: String
-IDBVersionChangeEvent[SO] def newVersionOption: Option[Int]
-IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Int]
+IDBVersionChangeEvent[SO] def newVersionOption: Option[Double]
+IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Double]
 IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
 IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
 IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
-IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Integer]
-IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Int]
+IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[java.lang.Double]
+IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Double]
 IDBVersionChangeEventInit[JT] var scoped: js.UndefOr[Boolean]
 ImageBitmap[JT] def close(): Unit
 ImageBitmap[JT] def height: Double
diff --git a/api-reports/2_13.txt b/api-reports/2_13.txt
@@ -14020,9 +14020,9 @@ IDBDatabase[JC] var onversionchange: js.Function1[IDBVersionChangeEvent, _]
 IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
 IDBDatabase[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
 IDBDatabase[JC] def transaction(storeNames: String | js.Array[String], mode: js.UndefOr[IDBTransactionMode]?, options: js.UndefOr[IDBTransactionOptions]?): IDBTransaction
-IDBDatabase[JC] def version: Int
+IDBDatabase[JC] def version: Double
 IDBDatabaseInfo[JT] val name: String
-IDBDatabaseInfo[JT] val version: Int
+IDBDatabaseInfo[JT] val version: Double
 IDBEnvironment[JT] def indexedDB: IDBFactory  (@deprecated in 1.2.0)
 IDBEvent[JC] def bubbles: Boolean
 IDBEvent[JC] def cancelBubble: Boolean
@@ -14047,7 +14047,7 @@ IDBEventTarget[JC] def result: A
 IDBFactory[JC] def cmp(first: IDBValue, second: IDBValue): Int
 IDBFactory[JC] def databases(): js.Promise[js.Array[IDBDatabaseInfo]]
 IDBFactory[JC] def deleteDatabase(name: String): IDBOpenDBRequest[Unit]
-IDBFactory[JC] def open(name: String, version: Int?): IDBOpenDBRequest[IDBDatabase]
+IDBFactory[JC] def open(name: String, version: Double?): IDBOpenDBRequest[IDBDatabase]
 IDBIndex[JC] def count(query: IDBKey | IDBKeyRange?): IDBRequest[S, Double]
 IDBIndex[JC] def get(key: IDBKey | IDBKeyRange): IDBRequest[S, IDBValue]
 IDBIndex[JC] def getAll(query: js.UndefOr[IDBKeyRange | IDBKey]?, count: js.UndefOr[Double]?): IDBRequest[S, js.Array[IDBValue]]
@@ -14150,22 +14150,22 @@ IDBVersionChangeEvent[JC] def currentTarget: EventTarget
 IDBVersionChangeEvent[JC] def defaultPrevented: Boolean
 IDBVersionChangeEvent[JC] def eventPhase: Int
 IDBVersionChangeEvent[JC] def isTrusted: Boolean
-IDBVersionChangeEvent[JC] def newVersion: Integer
-IDBVersionChangeEvent[JC] def oldVersion: Int
+IDBVersionChangeEvent[JC] def newVersion: java.lang.Double
+IDBVersionChangeEvent[JC] def oldVersion: Double
 IDBVersionChangeEvent[JC] def preventDefault(): Unit
 IDBVersionChangeEvent[JC] def stopImmediatePropagation(): Unit
 IDBVersionChangeEvent[JC] def stopPropagation(): Unit
 IDBVersionChangeEvent[JC] def target: EventTarget
 IDBVersionChangeEvent[JC] override def target: IDBEventTarget[A]
 IDBVersionChangeEvent[JC] def timeStamp: Double
 IDBVersionChangeEvent[JC] def `type`: String
-IDBVersionChangeEvent[SO] def newVersionOption: Option[Int]
-IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Int]
+IDBVersionChangeEvent[SO] def newVersionOption: Option[Double]
+IDBVersionChangeEvent.Ops[SC] def newVersionOption: Option[Double]
 IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
 IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
 IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
-IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Integer]
-IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Int]
+IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[java.lang.Double]
+IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Double]
 IDBVersionChangeEventInit[JT] var scoped: js.UndefOr[Boolean]
 ImageBitmap[JT] def close(): Unit
 ImageBitmap[JT] def height: Double
diff --git a/dom/src/main/scala/org/scalajs/dom/IDBDatabase.scala b/dom/src/main/scala/org/scalajs/dom/IDBDatabase.scala
@@ -26,7 +26,7 @@ class IDBDatabase extends EventTarget {
     * you should use [[IDBVersionChangeEvent#newVersion]] instead. Webkit returns always integer and the value is 1 when
     * database is first created.
     */
-  def version: Int = js.native
+  def version: Double = js.native
 
   /** A DOMString that contains the name of the connected database. */
   def name: String = js.native
diff --git a/dom/src/main/scala/org/scalajs/dom/IDBDatabaseInfo.scala b/dom/src/main/scala/org/scalajs/dom/IDBDatabaseInfo.scala
@@ -11,5 +11,5 @@ import scala.scalajs.js
 @js.native
 trait IDBDatabaseInfo extends js.Object {
   val name: String = js.native
-  val version: Int = js.native
+  val version: Double = js.native
 }
diff --git a/dom/src/main/scala/org/scalajs/dom/IDBFactory.scala b/dom/src/main/scala/org/scalajs/dom/IDBFactory.scala
@@ -25,7 +25,7 @@ class IDBFactory extends js.Object {
     *
     * w3c spec [[http://www.w3.org/TR/IndexedDB/#requests ¶3.2.3 Opening a database]]
     */
-  def open(name: String, version: Int = js.native): IDBOpenDBRequest[IDBDatabase] = js.native
+  def open(name: String, version: Double = js.native): IDBOpenDBRequest[IDBDatabase] = js.native
 
   /** Compares two values as keys to determine equality and ordering for IndexedDB operations, such as storing and
     * iterating.
diff --git a/dom/src/main/scala/org/scalajs/dom/IDBVersionChangeEvent.scala b/dom/src/main/scala/org/scalajs/dom/IDBVersionChangeEvent.scala
@@ -21,10 +21,10 @@ class IDBVersionChangeEvent(typeArg: String, init: js.UndefOr[IDBVersionChangeEv
     *
     * This is null when the database is being deleted.
     */
-  def newVersion: Integer = js.native
+  def newVersion: java.lang.Double = js.native
 
   /** Returns the old version of the database. */
-  def oldVersion: Int = js.native
+  def oldVersion: Double = js.native
 }
 
 object IDBVersionChangeEvent {
@@ -35,10 +35,10 @@ object IDBVersionChangeEvent {
       *
       * This is None when the database is being deleted.
       */
-    def newVersionOption: Option[Int] =
+    def newVersionOption: Option[Double] =
       (e.newVersion: Any) match {
-        case i: Int => Some(i)
-        case _      => None
+        case i: Double => Some(i)
+        case _         => None
       }
   }
 }
diff --git a/dom/src/main/scala/org/scalajs/dom/IDBVersionChangeEventInit.scala b/dom/src/main/scala/org/scalajs/dom/IDBVersionChangeEventInit.scala
@@ -9,6 +9,6 @@ package org.scalajs.dom
 import scala.scalajs.js
 
 trait IDBVersionChangeEventInit extends EventInit {
-  var newVersion: js.UndefOr[Integer] = js.undefined
-  var oldVersion: js.UndefOr[Int] = js.undefined
+  var newVersion: js.UndefOr[java.lang.Double] = js.undefined
+  var oldVersion: js.UndefOr[Double] = js.undefined
 }

Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,5 @@ import scala.scalajs.js`
`11`	`11`	`@js.native`
`12`	`12`	`trait IDBDatabaseInfo extends js.Object {`
`13`	`13`	`val name: String = js.native`
`14`		`- val version: Int = js.native`
	`14`	`+ val version: Double = js.native`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class IDBFactory extends js.Object {`
`25`	`25`	`*`
`26`	`26`	`* w3c spec [[http://www.w3.org/TR/IndexedDB/#requests ¶3.2.3 Opening a database]]`
`27`	`27`	`*/`
`28`		`- def open(name: String, version: Int = js.native): IDBOpenDBRequest[IDBDatabase] = js.native`
	`28`	`+ def open(name: String, version: Double = js.native): IDBOpenDBRequest[IDBDatabase] = js.native`
`29`	`29`
`30`	`30`	`/** Compares two values as keys to determine equality and ordering for IndexedDB operations, such as storing and`
`31`	`31`	`* iterating.`
Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,10 @@ class IDBVersionChangeEvent(typeArg: String, init: js.UndefOr[IDBVersionChangeEv`
`21`	`21`	`*`
`22`	`22`	`* This is null when the database is being deleted.`
`23`	`23`	`*/`
`24`		`- def newVersion: Integer = js.native`
	`24`	`+ def newVersion: java.lang.Double = js.native`
`25`	`25`
`26`	`26`	`/** Returns the old version of the database. */`
`27`		`- def oldVersion: Int = js.native`
	`27`	`+ def oldVersion: Double = js.native`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`object IDBVersionChangeEvent {`
`@@ -35,10 +35,10 @@ object IDBVersionChangeEvent {`
`35`	`35`	`*`
`36`	`36`	`* This is None when the database is being deleted.`
`37`	`37`	`*/`
`38`		`- def newVersionOption: Option[Int] =`
	`38`	`+ def newVersionOption: Option[Double] =`
`39`	`39`	`(e.newVersion: Any) match {`
`40`		`- case i: Int => Some(i)`
`41`		`- case _ => None`
	`40`	`+ case i: Double => Some(i)`
	`41`	`+ case _ => None`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ package org.scalajs.dom`
`9`	`9`	`import scala.scalajs.js`
`10`	`10`
`11`	`11`	`trait IDBVersionChangeEventInit extends EventInit {`
`12`		`- var newVersion: js.UndefOr[Integer] = js.undefined`
`13`		`- var oldVersion: js.UndefOr[Int] = js.undefined`
	`12`	`+ var newVersion: js.UndefOr[java.lang.Double] = js.undefined`
	`13`	`+ var oldVersion: js.UndefOr[Double] = js.undefined`
`14`	`14`	`}`