chore: add tests for transforms

Author: markehammons

.github/workflows/benchmarks.yml

@@ -20,8 +20,7 @@ jobs:
       - uses: VirtusLab/scala-cli-setup@v0.1.20
         with:
           jvm: temurin:1.${{ matrix.jvm }}
-          apps: mill
-      - run: mill j${{ matrix.jvm }}.benchmarks.test -f1 -wi 2 -i 2 -o j${{ matrix.jvm }}-${{ matrix.os }}.bench -rff j${{ matrix.jvm }}-${{ matrix.os }}.json -rf json .*${{ matrix.benchmark }}${{ matrix.jit }}.*
+      - run: ./mill j${{ matrix.jvm }}.benchmarks.test -f1 -wi 2 -i 2 -o j${{ matrix.jvm }}-${{ matrix.os }}.bench -rff j${{ matrix.jvm }}-${{ matrix.os }}.json -rf json .*${{ matrix.benchmark }}${{ matrix.jit }}.*
       - run: scala-cli run scripts/PublishBenchmarkReport.sc -- "Java ${{ matrix.jvm}}" ${{ matrix.os }} out/j${{ matrix.jvm }}/benchmarks/test/jmhRun.dest/j${{ matrix.jvm }}-${{ matrix.os }}.json ${{ matrix.benchmark }} ${{ matrix.jit }} >> $GITHUB_STEP_SUMMARY
       - uses: actions/upload-artifact@v3
         with:

.github/workflows/ci.yml

@@ -15,8 +15,7 @@ jobs:
       - uses: coursier/setup-action@v1.3.0
         with:
           jvm: temurin:1.17
-          apps: mill
-      - run: mill mill.scalalib.scalafmt.ScalafmtModule/checkFormatAll __.sources
+      - run: ./mill mill.scalalib.scalafmt.ScalafmtModule/checkFormatAll __.sources
 
   unit-tests:
     strategy: 

core/src/fr/hammons/slinc/DescriptorOf.scala

@@ -58,6 +58,8 @@ object DescriptorOf:
   given DescriptorOf[VarArgs] with
     val descriptor: TypeDescriptor { type Inner = VarArgs } = VaListDescriptor
 
+  given [A](using t: Transform[A, ?]): DescriptorOf[A] = t
+
   def getDescriptorFor[A](using Quotes, Type[A]) =
     import quotes.reflect.*
     val expr = Expr

core/src/fr/hammons/slinc/Transform.scala

@@ -11,9 +11,3 @@ trait Transform[A, B](using val desc: DescriptorOf[B])(
       type Inner = A
       val transformFrom = _transformFrom
       val transformTo = _transformTo
-
-object Transform:
-  given Transform[Boolean, Byte](
-    b => if b != (0: Byte) then true else false,
-    b => if b then 1: Byte else 0: Byte
-  )

core/src/fr/hammons/slinc/types/Basic.scala

@@ -1,8 +1,26 @@
 package fr.hammons.slinc.types
 
+import fr.hammons.slinc.Transform
+
 type CChar = Byte
 type CShort = Short
 type CInt = Int
 type CFloat = Float
 type CDouble = Double
 type CLongLong = Long
+
+opaque type CBool >: Boolean <: Boolean = Boolean
+
+object CBool:
+  given Transform[CBool, Byte](
+    b => if b != (0: Byte) then true else false,
+    b => if b then 1: Byte else 0: Byte
+  )
+
+opaque type CBoolShort >: Boolean <: Boolean = Boolean
+
+object CBoolShort:
+  given Transform[CBoolShort, Short](
+    s => if s != (0: Short) then true else false,
+    b => if b then 1: Short else 0: Short
+  )

core/test/native/test.c

@@ -147,4 +147,8 @@ EXPORTED int* i180_test(int my_array[5]) {
     i++;
   }
   return my_array;
+}
+
+EXPORTED char i213_test(char bool) {
+  return bool;
 }

core/test/resources/native/test.c

@@ -63,6 +63,8 @@ trait BindingSpec(val slinc: Slinc) extends ScalaCheckSuite:
         input: SetSizeArray[CInt, 5]
     ): SetSizeArray[CInt, 5]
 
+    def i213_test(b: CBool): CBool
+
   test("int_identity") {
     val test = FSet.instance[TestLib]
 
@@ -198,3 +200,8 @@ trait BindingSpec(val slinc: Slinc) extends ScalaCheckSuite:
         val retArr = test.i180_test(arr)
 
         retArr.zip(arr.map(_ * 2)).foreach(assertEquals(_, _))
+
+  property("issue 213 - can send and receive boolean values"):
+      val test = FSet.instance[TestLib]
+      forAll: (b: Boolean) =>
+        assertEquals(test.i213_test(b), b)

core/test/src/fr/hammons/slinc/BindingSpec.scala

@@ -25,3 +25,25 @@ class TypeDescriptorSpec extends munit.FunSuite:
           )
         ): TypeDescriptor
       )
+
+  test("Transforms work in place of DescriptorOfs"):
+      val result = compileErrors(
+        """
+        import fr.hammons.slinc.types.*
+        
+        trait Test derives FSet{
+        def test(a: CBool): CBool
+        def test2(a: CBoolShort): CBoolShort
+        }
+
+        val runtime: Slinc = ???
+
+        import runtime.{*,given}
+        val test = FSet.instance[Test]
+
+        val bool: Boolean = test.test(true)
+        val bool2: Boolean = test.test2(true)
+      """
+      )
+
+      assertNoDiff(result, "")