Commit d2fcc5f
authored
Fix Rule 1b violation in PowerQuery List() (#238)
* Fix Rule 1b violation in PowerQuery List() outer catch block
- Remove catch block creating fake 'Error Query' entries
- Replace with continue statement to skip problematic queries
- Prevents exception suppression (Rule 1b compliance)
- Allows fault-tolerant listing: one bad query doesn't break entire list
- All 16 PowerQuery tests pass
* Remove inefficient try-catch in PowerQuery Refresh()
- Remove inner try-catch that suppressed COMException
- Let exceptions propagate naturally (Rule 1b)
- Remove complex fallback logic checking Success flag
- Simpler, more efficient: just throw on error
- All 16 PowerQuery tests pass
* Enforce sequential test execution and remove obsolete test
- Add xunit.runner.json to all test projects (Core, CLI, McpServer)
- Configure parallelizeAssembly: false, maxParallelThreads: 1
- Remove obsolete VbaCommandsTests.Trust.TrustScope.cs (skipped test)
- Ensures stable test execution for Excel COM interop1 parent 2828175 commit d2fcc5f
File tree
6 files changed
+30
-59
lines changed- src/ExcelMcp.Core/Commands/PowerQuery
- tests
- ExcelMcp.CLI.Tests
- ExcelMcp.Core.Tests
- Integration/Commands/Vba
- ExcelMcp.McpServer.Tests
6 files changed
+30
-59
lines changedLines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
| 142 | + | |
143 | 143 | | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
151 | 148 | | |
152 | 149 | | |
153 | 150 | | |
| |||
Lines changed: 7 additions & 37 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 55 | + | |
| 56 | + | |
73 | 57 | | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
81 | 61 | | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
| 62 | + | |
| 63 | + | |
94 | 64 | | |
95 | 65 | | |
96 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
Lines changed: 0 additions & 14 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
0 commit comments