fix: delete multiple tables from lib pane

Signed-off-by: Irene Sanchez <irene.iscc777@gmail.com>

Author: IreneS1

client/src/components/LibraryNavigator/LibraryDataProvider.ts

@@ -50,6 +50,10 @@ class LibraryDataProvider
     return this._onDidChangeTreeData.event;
   }
 
+  get treeView(): TreeView<LibraryItem> {
+    return this._treeView;
+  }
+
   constructor(
     private readonly model: LibraryModel,
     private readonly extensionUri: Uri,
@@ -170,6 +174,11 @@ class LibraryDataProvider
     this._onDidChangeTreeData.fire(undefined);
   }
 
+  public async deleteTables(items: LibraryItem[]): Promise<void> {
+    await this.model.deleteTables(items);
+    this._onDidChangeTreeData.fire(undefined);
+  }
+
   public watch(): Disposable {
     // ignore, fires for all changes...
     return new Disposable(() => {});

client/src/components/LibraryNavigator/LibraryModel.ts

@@ -126,6 +126,28 @@ class LibraryModel {
     }
   }
 
+  public async deleteTables(items: LibraryItem[]) {
+    const failures: string[] = [];
+
+    for (const item of items) {
+      try {
+        await this.libraryAdapter.deleteTable(item);
+      } catch {
+        failures.push(item.uid);
+      }
+    }
+
+    if (failures.length > 0) {
+      throw new Error(
+        //TODO: look at what warning message dialog is being used throughout the codebase
+        l10n.t(Messages.TablesDeletionWarning, {
+          tableNames: failures.join(", "),
+          count: failures.length,
+        }),
+      );
+    }
+  }
+
   public async getTableInfo(item: LibraryItem) {
     if (this.libraryAdapter.getTableInfo) {
       await this.libraryAdapter.setup();

client/src/components/LibraryNavigator/const.ts

@@ -4,6 +4,9 @@ import { l10n } from "vscode";
 
 export const Messages = {
   TableDeletionError: l10n.t("Unable to delete table {tableName}."),
+  TablesDeletionWarning: l10n.t(
+    "Are you sure you want to delete {count} table(s): {tableNames}?",
+  ),
   ViewTableCommandTitle: l10n.t("View SAS Table"),
 };
 

client/src/components/LibraryNavigator/index.ts

@@ -7,6 +7,7 @@ import {
   Uri,
   commands,
   env,
+  l10n,
   window,
   workspace,
 } from "vscode";
@@ -24,6 +25,7 @@ import LibraryAdapterFactory from "./LibraryAdapterFactory";
 import LibraryDataProvider from "./LibraryDataProvider";
 import LibraryModel from "./LibraryModel";
 import PaginatedResultSet from "./PaginatedResultSet";
+import { Messages } from "./const";
 import { LibraryAdapter, LibraryItem, TableData } from "./types";
 
 class LibraryNavigator implements SubscriptionProvider {
@@ -63,8 +65,34 @@ class LibraryNavigator implements SubscriptionProvider {
       ),
       commands.registerCommand("SAS.refreshLibraries", () => this.refresh()),
       commands.registerCommand("SAS.deleteTable", async (item: LibraryItem) => {
+        const selectedItems = this.treeViewSelections(item);
+
+        if (selectedItems.length === 0) {
+          return;
+        }
+
         try {
-          await this.libraryDataProvider.deleteTable(item);
+          if (selectedItems.length === 1) {
+            await this.libraryDataProvider.deleteTable(selectedItems[0]);
+          } else {
+            const tableNames = selectedItems
+              .map((table) => `${table.library}.${table.name}`)
+              .join(", ");
+
+            const result = await window.showWarningMessage(
+              l10n.t(Messages.TablesDeletionWarning, {
+                tableNames: tableNames,
+              }),
+              { modal: true },
+              "Delete",
+            );
+
+            if (result !== "Delete") {
+              return;
+            }
+
+            await this.libraryDataProvider.deleteTables(selectedItems);
+          }
         } catch (error) {
           window.showErrorMessage(error.message);
         }
@@ -143,6 +171,15 @@ class LibraryNavigator implements SubscriptionProvider {
     this.libraryDataProvider.useAdapter(this.libraryAdapterForConnectionType());
   }
 
+  private treeViewSelections(item: LibraryItem): LibraryItem[] {
+    const items =
+      this.libraryDataProvider.treeView.selection.length > 1 || !item
+        ? this.libraryDataProvider.treeView.selection
+        : [item];
+
+    return items.filter(Boolean);
+  }
+
   private libraryAdapterForConnectionType(): LibraryAdapter | undefined {
     const activeProfile = profileConfig.getProfileByName(
       profileConfig.getActiveProfile(),