convert nan to null

Author: jlwalke2

CHANGELOG.md

@@ -1,7 +1,8 @@
 
 Unreleased
 ----------
- - 
+**Bugfixes**
+ - Convert NaN values to null (None) when calling `microanalytic_score.execute_module_step`.
 
 v1.2.2 (2019-8-21)
 ------------------

src/sasctl/_services/microanalytic_score.py

@@ -8,6 +8,7 @@
 
 import re
 from collections import OrderedDict
+from math import isnan
 
 import six
 
@@ -127,9 +128,17 @@ def execute_module_step(self, module, step, return_dict=True, **kwargs):
             elif type_name == 'int64':
                 kwargs[k] = int(kwargs[k])
 
-
         body = {'inputs': [{'name': k, 'value': v}
                            for k, v in six.iteritems(kwargs)]}
+
+        # Convert NaN to None (null) before calling MAS
+        for input in body['inputs']:
+            try:
+                if isnan(input['value']):
+                    input['value']  = None
+            except TypeError:
+                pass
+
         r = self.post('/modules/{}/steps/{}'.format(module, step), json=body)
 
         # Convert list of name/value pair dictionaries to single dict

tests/unit/test_pymas.py

@@ -504,3 +504,42 @@ def domath(a, b):
     result = package.code()
     assert target.lstrip('\n') == result
     assert '\t' not in result
+
+
+def test_bugfix_27():
+    """NaN values should be converted to null before being sent to MAS
+
+    https://github.com/sassoftware/python-sasctl/issues/27
+    """
+
+    import io
+    from sasctl.core import RestObj
+    from sasctl.services import microanalytic_score as mas
+    pd = pytest.importorskip('pandas')
+
+    df = pd.read_csv(io.StringIO('\n'.join([
+        'BAD,LOAN,MORTDUE,VALUE,REASON,JOB,YOJ,DEROG,DELINQ,CLAGE,NINQ,CLNO,DEBTINC',
+        '0,1.0,1100.0,25860.0,39025.0,HomeImp,Other,10.5,0.0,0.0,94.36666667,1.0,9.0,',
+        '1,1.0,1300.0,70053.0,68400.0,HomeImp,Other,7.0,0.0,2.0,121.8333333,0.0,14.0,'
+    ])))
+
+    with mock.patch('sasctl._services.microanalytic_score.MicroAnalyticScore.get_module') as get_module:
+        get_module.return_value = RestObj({
+            'name': 'Mock Module',
+            'id': 'mockmodule'
+        })
+        with mock.patch('sasctl._services.microanalytic_score.MicroAnalyticScore.post') as post:
+            x = df.iloc[0, :]
+            mas.execute_module_step('module', 'step', **x)
+
+    # Ensure we're passing NaN to execute_module_step
+    assert pd.isna(x['DEBTINC'])
+
+    # Make sure the value has been converted to None before being serialized to JSON.
+    # This ensures that the JSON value will be null.
+    json = post.call_args[1]['json']
+    inputs = json['inputs']
+    debtinc = [i for i in inputs if i['name'] == 'DEBTINC'].pop()
+    assert debtinc['value'] is None
+
+