fix: avoid using asdict in combine-reducers's reducer as it can get too costly for large dataclasses and may even run into errors

Author: sassanh

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Upcoming
+
+- fix: avoid using `asdict` in combine-reducers's reducer as it can get too costly for large dataclasses and may even run into errors
+
 ## Version 0.20.0
 
 - feat: add `memoization` option to `autorun`, default is `True`, compatible with old behavior, if set to `False`, calling the function explicitly will always run it regardless of the selector's value

pyproject.toml

@@ -13,8 +13,8 @@ dependencies = ["python-immutable >= 1.1.1", "python-strtobool >= 1.0.0"]
 [tool.uv]
 dev-dependencies = [
   "poethepoet >= 0.24.4",
-  "pyright >= 1.1.376",
-  "ruff >= 0.6.0",
+  "pyright >= 1.1.396",
+  "ruff >= 0.9.10",
   "pytest >= 8.1.1",
   "pytest-cov >= 4.1.0",
   "pytest-timeout >= 2.3.1",

redux/combine_reducers.py

@@ -5,7 +5,7 @@
 import functools
 import operator
 import uuid
-from dataclasses import asdict, fields
+from dataclasses import fields
 from typing import TYPE_CHECKING, Any, TypeVar, cast
 
 from immutable import make_immutable
@@ -74,18 +74,16 @@ def combined_reducer(
                 )
                 state = state_class(
                     _id=state._id,  # noqa: SLF001
-                    **(
-                        {
-                            key_: (
-                                reducer_result.state
-                                if is_complete_reducer_result(reducer_result)
-                                else reducer_result
-                            )
-                            if key == key_
-                            else getattr(state, key_)
-                            for key_ in reducers
-                        }
-                    ),
+                    **{
+                        key_: (
+                            reducer_result.state
+                            if is_complete_reducer_result(reducer_result)
+                            else reducer_result
+                        )
+                        if key == key_
+                        else getattr(state, key_)
+                        for key_ in reducers
+                    },
                 )
                 result_actions += (
                     reducer_result.actions or []
@@ -109,11 +107,8 @@ def combined_reducer(
                 cast(Any, state_class).__dataclass_fields__ = fields_copy
 
                 state = state_class(
-                    **{
-                        key_: getattr(state, key_)
-                        for key_ in asdict(state)
-                        if key_ != key
-                    },
+                    _id=state._id,  # noqa: SLF001
+                    **{key_: getattr(state, key_) for key_ in reducers if key_ != key},
                 )
 
         reducers_results = {