refactor: no error if an unsubscription function is called multiple times

Author: sassanh

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Version 0.9.24
+
+- refactor: no error if an unsubscription function is called multiple times
+
 ## Version 0.9.23
 
 - feat(combine_reducers): initialization of sub-reducers is done with `CombineReducerInitAction`

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "python-redux"
-version = "0.9.23"
+version = "0.9.24"
 description = "Redux implementation for Python"
 authors = ["Sassan Haradji <sassanh@gmail.com>"]
 license = "Apache-2.0"

redux/main.py

@@ -105,7 +105,7 @@ def run() -> None:
                             if isinstance(listener_, weakref.ref):
                                 listener = listener_()
                                 if listener is None:
-                                    listeners.remove(listener_)
+                                    listeners.discard(listener_)
                                     continue
                             else:
                                 listener = listener_
@@ -117,7 +117,7 @@ def run() -> None:
                         if isinstance(event_handler_, weakref.ref):
                             event_handler = event_handler_()
                             if event_handler is None:
-                                event_handlers[type(event)].remove(
+                                event_handlers[type(event)].discard(
                                     (event_handler_, options),
                                 )
                                 continue
@@ -182,7 +182,7 @@ def subscribe_event(
         event_handlers[cast(type[Event], event_type)].add(
             (handler_ref, subscription_options),
         )
-        return lambda: event_handlers[cast(type[Event], event_type)].remove(
+        return lambda: event_handlers[cast(type[Event], event_type)].discard(
             (handler_ref, subscription_options),
         )
 
@@ -255,7 +255,7 @@ def check_and_call(state: State) -> None:
                         if isinstance(subscriber_, weakref.ref):
                             subscriber = subscriber_()
                             if subscriber is None:
-                                subscriptions.remove(subscriber_)
+                                subscriptions.discard(subscriber_)
                                 continue
                         else:
                             subscriber = subscriber_
@@ -291,7 +291,7 @@ def subscribe(
                         callback(self.value)
 
                     def unsubscribe() -> None:
-                        subscriptions.remove(callback_ref)
+                        subscriptions.discard(callback_ref)
 
                     return unsubscribe