fix: add __name__ to WithStore instances so that they play nice when passed as a function to something assuming they are functions and have a __name__ attribute

Author: sassanh

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Upcoming
+
+- fix: add `__name__` to `WithStore` instances so that they play nice when passed as a function to something assuming they are functions and have a `__name__` attribute
+
 ## Version 0.22.0
 
 - test: make sure pytest exits completely after running async tests

pyproject.toml

@@ -13,8 +13,8 @@ dependencies = ["python-immutable >= 1.1.1", "python-strtobool >= 1.0.0"]
 [tool.uv]
 dev-dependencies = [
   "poethepoet >= 0.24.4",
-  "pyright >= 1.1.396",
-  "ruff >= 0.10.0",
+  "pyright >= 1.1.397",
+  "ruff >= 0.11.0",
   "pytest >= 8.1.1",
   "pytest-cov >= 4.1.0",
   "pytest-timeout >= 2.3.1",

redux/autorun.py

@@ -65,8 +65,8 @@ class Autorun(
         Event,
         SelectorOutput,
         ComparatorOutput,
-        ReturnType,
         Args,
+        ReturnType,
     ],
 ):
     """Run a wrapped function in response to specific state changes in the store."""
@@ -84,7 +84,10 @@ def __init__(
         options: AutorunOptions[ReturnType],
     ) -> None:
         """Initialize the Autorun instance."""
-        self.__name__ = func.__name__
+        if hasattr(func, '__name__'):
+            self.__name__ = f'Autorun:{func.__name__}'
+        else:
+            self.__name__ = f'Autorun:{func}'
         self._store = store
         self._selector = selector
         self._comparator = comparator
@@ -147,8 +150,8 @@ def unsubscribe(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
         _: weakref.ref | None = None,
     ) -> None:
@@ -164,8 +167,8 @@ def inform_subscribers(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
     ) -> None:
         """Inform all subscribers about the latest value."""
@@ -186,8 +189,8 @@ def _task_callback(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
         task: Task,
         *,
@@ -207,8 +210,8 @@ def _check(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
         state: State | None,
     ) -> bool:
@@ -239,8 +242,8 @@ def _call(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
         *args: Args.args,
         **kwargs: Args.kwargs,
@@ -287,8 +290,8 @@ def __call__(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
         *args: Args.args,
         **kwargs: Args.kwargs,
@@ -307,8 +310,8 @@ def __repr__(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
     ) -> str:
         """Return a string representation of the Autorun instance."""
@@ -325,8 +328,8 @@ def value(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
     ) -> ReturnType:
         """Get the latest value of the autorun function."""
@@ -339,8 +342,8 @@ def subscribe(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
         callback: Callable[[ReturnType], Any],
         *,
@@ -376,8 +379,8 @@ def __signature__(
             Event,
             SelectorOutput,
             ComparatorOutput,
-            ReturnType,
             Args,
+            ReturnType,
         ],
     ) -> inspect.Signature:
         """Get the signature of the wrapped function."""

redux/main.py

@@ -124,9 +124,7 @@ def _call_listeners(self: Store[State, Action, Event], state: State) -> None:
         for listener_ in self._listeners.copy():
             if isinstance(listener_, weakref.ref):
                 listener = listener_()
-                if listener is None:
-                    self._listeners.discard(listener_)
-                    continue
+                assert listener is not None  # noqa: S101
             else:
                 listener = listener_
             result = listener(state)
@@ -297,7 +295,6 @@ def _wait_for_store_to_finish(self: Store[State, Action, Event]) -> None:
                 if self.store_options.on_finish:
                     self.store_options.on_finish()
                 break
-            self.run()
 
     def _handle_finish_event(self: Store[State, Action, Event]) -> None:
         Thread(target=self._wait_for_store_to_finish).start()

redux/with_state.py

@@ -27,6 +27,10 @@ def __init__(
         ],
     ) -> None:
         """Initialize the WithState instance."""
+        if hasattr(func, '__name__'):
+            self.__name__ = f'WithState:{func.__name__}'
+        else:
+            self.__name__ = f'WithState:{func}'
         self._store = store
         self._selector = selector
         self._func = func

tests/test_autorun.py

@@ -88,7 +88,7 @@ def decorated(value: int) -> int:
         store_snapshot.take()
         return value
 
-    assert decorated.__name__ == 'decorated'
+    assert decorated.__name__ == 'Autorun:decorated'
 
 
 def test_ignore_attribute_error_in_selector(store: StoreType) -> None: