feat: all subscriptions/listeners with keep_ref, now use WeakMethod for methods

Author: sassanh

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Version 0.9.25
+
+- feat: all subscriptions/listeners with `keep_ref`, now use `WeakMethod` for methods
+
 ## Version 0.9.24
 
 - refactor: no error if an unsubscription function is called multiple times

redux/combine_reducers.py

@@ -2,6 +2,8 @@
 from __future__ import annotations
 
 import copy
+import functools
+import operator
 import uuid
 from dataclasses import asdict, make_dataclass
 from typing import TYPE_CHECKING, Any, TypeVar, cast
@@ -152,14 +154,16 @@ def combined_reducer(
                 for key, result in reducers_results.items()
             },
         )
-        result_actions += sum(
+        result_actions += functools.reduce(
+            operator.iadd,
             [
                 result.actions or [] if is_reducer_result(result) else []
                 for result in reducers_results.values()
             ],
             [],
         )
-        result_events += sum(
+        result_events += functools.reduce(
+            operator.iadd,
             [
                 result.events or [] if is_reducer_result(result) else []
                 for result in reducers_results.values()

redux/main.py

@@ -7,6 +7,7 @@
 from collections import defaultdict
 from inspect import signature
 from threading import Lock
+from types import MethodType
 from typing import Any, Callable, Generic, cast
 
 from .basic_types import (
@@ -162,7 +163,12 @@ def subscribe(
         *,
         keep_ref: bool = True,
     ) -> Callable[[], None]:
-        listener_ref = listener if keep_ref else weakref.ref(listener)
+        if keep_ref:
+            listener_ref = listener
+        elif isinstance(listener, MethodType):
+            listener_ref = weakref.WeakMethod(listener)
+        else:
+            listener_ref = weakref.ref(listener)
 
         listeners.add(listener_ref)
         return lambda: listeners.remove(listener_ref)
@@ -177,7 +183,12 @@ def subscribe_event(
             EventSubscriptionOptions() if options is None else options
         )
 
-        handler_ref = handler if subscription_options.keep_ref else weakref.ref(handler)
+        if subscription_options.keep_ref:
+            handler_ref = handler
+        elif isinstance(handler, MethodType):
+            handler_ref = weakref.WeakMethod(handler)
+        else:
+            handler_ref = weakref.ref(handler)
 
         event_handlers[cast(type[Event], event_type)].add(
             (handler_ref, subscription_options),
@@ -284,7 +295,12 @@ def subscribe(
                     | None = autorun_options.subscribers_immediate_run,
                     keep_ref: bool | None = autorun_options.subscribers_keep_ref,
                 ) -> Callable[[], None]:
-                    callback_ref = callback if keep_ref else weakref.ref(callback)
+                    if keep_ref:
+                        callback_ref = callback
+                    elif isinstance(callback, MethodType):
+                        callback_ref = weakref.WeakMethod(callback)
+                    else:
+                        callback_ref = weakref.ref(callback)
                     subscriptions.add(callback_ref)
 
                     if immediate_run: