refactor: in _wait_for_store_to_finish, instead of waiting with asyncio.sleep, runs the store event loop when conditions are not satisfied

Author: sassanh

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Upcoming
 
 - test: make sure pytest exits completely after running async tests
+- refactor: in `_wait_for_store_to_finish`, instead of waiting with `asyncio.sleep`, run the store event loop when conditions are not satisfied
 
 ## Version 0.21.1
 

redux/autorun.py

@@ -128,12 +128,18 @@ def __init__(
             self._call()
 
         if self._options.reactive:
-            self._unsubscribe = store._subscribe(  # noqa: SLF001
-                lambda state: self._call() if self._check(state) else None,
-            )
+            self._unsubscribe = store._subscribe(self._react)  # noqa: SLF001
         else:
             self._unsubscribe = None
 
+    def _react(
+        self: Autorun,
+        state: State,
+    ) -> None:
+        """React to state changes in the store."""
+        if self._options.reactive and self._check(state):
+            self._call()
+
     def unsubscribe(
         self: Autorun[
             State,

redux/side_effect_runner.py

@@ -1,4 +1,4 @@
-"""Redux store for managing state and side effects."""
+"""Side effect runner thread for Redux."""
 
 from __future__ import annotations
 
@@ -28,6 +28,7 @@ def __init__(
     ) -> None:
         """Initialize the side effect runner thread."""
         super().__init__()
+        self.name = 'Side Effect Runner'
         self.task_queue = task_queue
         self.loop = asyncio.get_event_loop()
         self._handles: set[Handle] = set()

tests/test_scheduler.py

@@ -89,8 +89,8 @@ async def call_callback(
         if self.stopped:
             return
         self.tasks.add(self.loop.create_task(asyncio.to_thread(callback)))
-        await asyncio.sleep(0.01)
         if interval:
+            await asyncio.sleep(0.01)
             self.tasks.add(
                 self.loop.create_task(self.call_callback(callback, interval=interval)),
             )