CI on Windows using AppVeyor

Author: dahlia

README.rst

@@ -9,6 +9,10 @@ libsass: SASS_ for Python
    :target: https://travis-ci.org/dahlia/libsass-python
    :alt: Build Status
 
+.. image:: https://ci.appveyor.com/api/projects/status/yghrs9jw7b67c0ia
+   :target: https://ci.appveyor.com/project/dahlia/libsass-python
+   :alt: Build Status (Windows)
+
 .. image:: https://img.shields.io/coveralls/dahlia/libsass-python.svg
    :target: https://coveralls.io/r/dahlia/libsass-python
    :alt: Coverage Status

appveyor.yml

@@ -0,0 +1,32 @@
+version: "{build}"
+environment:
+  global:
+    VS90COMNTOOLS: "%VS110COMNTOOLS%"
+    VS100COMNTOOLS: "%VS110COMNTOOLS%"
+  matrix:
+  - PYTHON: "C:\\Python34_32"
+    PYTHON_VERSION: "3.4.1"
+    PYTHON_ARCH: "32"
+  - PYTHON: "C:\\Python34_64"
+    PYTHON_VERSION: "3.4.1"
+    PYTHON_ARCH: "64"
+matrix:
+  fast_finish: true
+init:
+- "ECHO %PYTHON%"
+- ps: "ls C:/Python*"
+install:
+- "git -C %APPVEYOR_BUILD_FOLDER% submodule update --init"
+- ps: (new-object net.webclient).DownloadFile('https://raw.githubusercontent.com/ogrisel/python-appveyor-demo/master/appveyor/install.ps1', 'C:/python-install.ps1')
+- "powershell C:/python-install.ps1"
+build: false
+test_script:
+- "%PYTHON%\\python.exe setup.py test"
+after_test:
+- ps: (new-object net.webclient).DownloadFile('https://bootstrap.pypa.io/get-pip.py', 'C:/get-pip.py')
+- "%PYTHON%\\python.exe C:/get-pip.py"
+- "%PYTHON%\\Scripts\\pip.exe --version"
+- "%PYTHON%\\Scripts\\pip.exe install wheel"
+- "%PYTHON%\\python.exe setup.py bdist_wheel"
+artifects:
+- path: dist\*

docs/index.rst

@@ -95,6 +95,15 @@ Travis CI
       :target: https://travis-ci.org/dahlia/libsass-python
       :alt: Build Status
 
+AppVeyor (CI for Windows)
+   https://ci.appveyor.com/project/dahlia/libsass-python
+
+   .. image:: https://ci.appveyor.com/api/projects/status/yghrs9jw7b67c0ia?retina=true
+      :target: https://ci.appveyor.com/project/dahlia/libsass-python
+      :alt: Build Status (Windows)
+      :width: 100
+      :height: 18
+
 Coveralls (Test coverage)
    https://coveralls.io/r/dahlia/libsass-python
 

ez_setup.py

@@ -26,12 +26,17 @@
 
 from distutils import log
 
+try:
+    from urllib.request import urlopen
+except ImportError:
+    from urllib2 import urlopen
+
 try:
     from site import USER_SITE
 except ImportError:
     USER_SITE = None
 
-DEFAULT_VERSION = "3.6"
+DEFAULT_VERSION = "5.7"
 DEFAULT_URL = "https://pypi.python.org/packages/source/s/setuptools/"
 
 def _python_cmd(*args):
@@ -64,17 +69,24 @@ def _build_egg(egg, archive_filename, to_dir):
         raise IOError('Could not build the egg.')
 
 
-def get_zip_class():
+class ContextualZipFile(zipfile.ZipFile):
     """
     Supplement ZipFile class to support context manager for Python 2.6
     """
-    class ContextualZipFile(zipfile.ZipFile):
-        def __enter__(self):
-            return self
-        def __exit__(self, type, value, traceback):
-            self.close
-    return zipfile.ZipFile if hasattr(zipfile.ZipFile, '__exit__') else \
-        ContextualZipFile
+
+    def __enter__(self):
+        return self
+
+    def __exit__(self, type, value, traceback):
+        self.close()
+
+    def __new__(cls, *args, **kwargs):
+        """
+        Construct a ZipFile or ContextualZipFile as appropriate
+        """
+        if hasattr(zipfile.ZipFile, '__exit__'):
+            return zipfile.ZipFile(*args, **kwargs)
+        return super(ContextualZipFile, cls).__new__(cls)
 
 
 @contextlib.contextmanager
@@ -85,7 +97,7 @@ def archive_context(filename):
     old_wd = os.getcwd()
     try:
         os.chdir(tmpdir)
-        with get_zip_class()(filename) as archive:
+        with ContextualZipFile(filename) as archive:
             archive.extractall()
 
         # going in the directory
@@ -183,14 +195,11 @@ def has_powershell():
     if platform.system() != 'Windows':
         return False
     cmd = ['powershell', '-Command', 'echo test']
-    devnull = open(os.path.devnull, 'wb')
-    try:
+    with open(os.path.devnull, 'wb') as devnull:
         try:
             subprocess.check_call(cmd, stdout=devnull, stderr=devnull)
         except Exception:
             return False
-    finally:
-        devnull.close()
     return True
 
 download_file_powershell.viable = has_powershell
@@ -201,14 +210,11 @@ def download_file_curl(url, target):
 
 def has_curl():
     cmd = ['curl', '--version']
-    devnull = open(os.path.devnull, 'wb')
-    try:
+    with open(os.path.devnull, 'wb') as devnull:
         try:
             subprocess.check_call(cmd, stdout=devnull, stderr=devnull)
         except Exception:
             return False
-    finally:
-        devnull.close()
     return True
 
 download_file_curl.viable = has_curl
@@ -219,14 +225,11 @@ def download_file_wget(url, target):
 
 def has_wget():
     cmd = ['wget', '--version']
-    devnull = open(os.path.devnull, 'wb')
-    try:
+    with open(os.path.devnull, 'wb') as devnull:
         try:
             subprocess.check_call(cmd, stdout=devnull, stderr=devnull)
         except Exception:
             return False
-    finally:
-        devnull.close()
     return True
 
 download_file_wget.viable = has_wget
@@ -236,45 +239,36 @@ def download_file_insecure(url, target):
     Use Python to download the file, even though it cannot authenticate the
     connection.
     """
+    src = urlopen(url)
     try:
-        from urllib.request import urlopen
-    except ImportError:
-        from urllib2 import urlopen
-    src = dst = None
-    try:
-        src = urlopen(url)
-        # Read/write all in one block, so we don't create a corrupt file
-        # if the download is interrupted.
+        # Read all the data in one block.
         data = src.read()
-        dst = open(target, "wb")
-        dst.write(data)
     finally:
-        if src:
-            src.close()
-        if dst:
-            dst.close()
+        src.close()
+
+    # Write all the data in one block to avoid creating a partial file.
+    with open(target, "wb") as dst:
+        dst.write(data)
 
 download_file_insecure.viable = lambda: True
 
 def get_best_downloader():
-    downloaders = [
+    downloaders = (
         download_file_powershell,
         download_file_curl,
         download_file_wget,
         download_file_insecure,
-    ]
-
-    for dl in downloaders:
-        if dl.viable():
-            return dl
+    )
+    viable_downloaders = (dl for dl in downloaders if dl.viable())
+    return next(viable_downloaders, None)
 
 def download_setuptools(version=DEFAULT_VERSION, download_base=DEFAULT_URL,
         to_dir=os.curdir, delay=15, downloader_factory=get_best_downloader):
     """
     Download setuptools from a specified location and return its filename
 
     `version` should be a valid setuptools version number that is available
-    as an egg for download under the `download_base` URL (which should end
+    as an sdist for download under the `download_base` URL (which should end
     with a '/'). `to_dir` is the directory where the egg will be downloaded.
     `delay` is the number of seconds to pause before an actual download
     attempt.

setup.py

@@ -52,6 +52,7 @@
     raise SystemExit(1)
 
 if sys.platform == 'win32':
+    from distutils.msvccompiler import MSVCCompiler
     from distutils.msvc9compiler import get_build_version
     vscomntools_env = 'VS{0}{1}COMNTOOLS'.format(
         int(get_build_version()),
@@ -65,6 +66,9 @@
     distutils.log.warn('%%%s%%=%s',
                        vscomntools_env,
                        os.environ.get(vscomntools_env, ''))
+    c = MSVCCompiler()
+    c.initialize()
+    distutils.log.warn('msvc_paths = %r', c.get_msvc_paths('path'))
     # Workaround http://bugs.python.org/issue4431 under Python <= 2.6
     if sys.version_info < (2, 7):
         def spawn(self, cmd):