Some more changes based on style guide. #6

Author: sagrawal31

dist/bootstrap-angular-validation.min.js

@@ -1,3 +1,5 @@
+/* global angular */
+
 'use strict';
 
 /**
@@ -10,10 +12,9 @@
  * Those element must have ng-model attributes. This directive will automatically add the 'has-error' class on the
  * parent element with class '.form-group' and will show/hide the validation message automatically.
 */
-
 angular.module('bootstrap.angular.validation').directive('bsValidation', [
   '$interpolate', 'BsValidationService',
-    function($interpolate, bsValidationService, $log) {
+    function($interpolate, bsValidationService) {
       return {
           restrict: 'A',
           require: ['ngModel', '^^form'],
@@ -24,7 +25,7 @@ angular.module('bootstrap.angular.validation').directive('bsValidation', [
 
             // HTML selector helper
             var errorElementClass = 'bs-invalid-msg';
-            var iconMarkup = '<i class=\'fa fa-exclamation-triangle fa-fw\'></i>';
+            var iconMarkup = '<i class="fa fa-exclamation-triangle fa-fw"></i>';
             var formGroup = '.form-group';
             var customFormGroup = '[bs-form-group]';
             var helpBlock = 'help-block';
@@ -48,7 +49,7 @@ angular.module('bootstrap.angular.validation').directive('bsValidation', [
             }
 
             var metaInformation = {};
-            angular.forEach(bsValidationService.getMeta(), function(key){
+            angular.forEach(bsValidationService.getMeta(), function(key) {
               metaInformation[key] = $element.attr(key);
             });
 
@@ -85,27 +86,27 @@ angular.module('bootstrap.angular.validation').directive('bsValidation', [
               return false;
             }
 
-            function addErrors(){
+            function addErrors() {
               addErrorClass();
               addErrorMessage();
               return false;
             }
 
-            function addSuccessClass(){
+            function addSuccessClass() {
               formGroupElement.addClass('has-success');
               return removeErrors();
             }
 
-            function addErrorClass(){
+            function addErrorClass() {
               formGroupElement.removeClass('has-success');
               formGroupElement.addClass('has-error');
             }
 
-            function renderError(message){
+            function renderError(message) {
               return '<span class="' + markupClasses + '">' + iconMarkup + message + '</span>';
             }
 
-            function errorContainer(message){
+            function errorContainer(message) {
               var insertAfter = $element;
               // Check if the container have any Bootstrap input group then append the error after it
               var groupElement = formGroupElement.findOne('.input-group');
@@ -115,17 +116,17 @@ angular.module('bootstrap.angular.validation').directive('bsValidation', [
               insertAfter.after(renderError(message));
             }
 
-            function addErrorMessage(){
+            function addErrorMessage() {
               var message = resolveMessage(Object.keys(ngModelController.$error)[0]);
               var errorElement = formGroupElement.findOne('.' + errorElementClass);
               if (errorElement.length === 0) { errorContainer(message); }
               errorElement.html(iconMarkup + message).removeClass('ng-hide');
             }
 
             function displayOrHideError() {
-              if(ngModelController.$valid){ return addSuccessClass(); }
-              if(ngModelController.$untouched){ return removeErrors(); }
-              if(ngModelController.$invalid){ return addErrors(); }
+              if (ngModelController.$valid) { return addSuccessClass(); }
+              if (ngModelController.$untouched) { return removeErrors(); }
+              if (ngModelController.$invalid) { return addErrors(); }
             }
 
           }

src/directives/validation.directive.js

@@ -27,25 +27,25 @@ angular.module('bootstrap.angular.validation').factory('BsValidationService', fu
 
   var genericValidators = {
     digits: function (value) {
-        return (/^\d+$/).test(value);
+      return (/^\d+$/).test(value);
     },
     equalto: function (value, $scope, attr) {
-        return value+'' === attr.equalto+'';
+      return value + '' === attr.equalto + '';
     },
     number: function (value) {
-        return (/^-?(?:\d+|\d{1,3}(?:,\d{3})+)?(?:\.\d+)?$/).test(value);
+      return (/^-?(?:\d+|\d{1,3}(?:,\d{3})+)?(?:\.\d+)?$/).test(value);
     },
     min: function (value, $scope, attr) {
-        return parseFloat(value) >= parseFloat(attr.min);
+      return parseFloat(value) >= parseFloat(attr.min);
     },
     max: function (value, $scope, attr) {
-        return parseFloat(value) <= parseFloat(attr.max);
+      return parseFloat(value) <= parseFloat(attr.max);
     },
     length: function (value, $scope, attr) {
-        return value.length === parseInt(attr.length);
+      return value.length === parseInt(attr.length);
     },
-    strictemail: function(value, $scope, attr) {
-      return  new RegExp(/^[_a-z0-9]+(\.[_a-z0-9]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,4})$/).test(value);
+    strictemail: function (value) {
+      return new RegExp(/^[_a-z0-9]+(\.[_a-z0-9]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,4})$/).test(value);
     }
   };
 
@@ -65,13 +65,13 @@ angular.module('bootstrap.angular.validation').factory('BsValidationService', fu
      * need not a add it for every form element.
      * @param $element
      */
-    getValidators: function (){
-      var builtIn = ['equalto', 'min', 'max', 'number', 'digits', 'length']
+    getValidators: function () {
+      var builtIn = ['equalto', 'min', 'max', 'number', 'digits', 'length'];
       var additional = Object.keys(genericValidators);
       return builtIn.concat(additional);
     },
 
-    getMeta: function (){
+    getMeta: function () {
       return ['matchName'];
     },
 
@@ -106,7 +106,7 @@ angular.module('bootstrap.angular.validation').factory('BsValidationService', fu
 
     getDefaultMessage: function (key) {
       return messages[key];
-    },
+    }
 
   };
 });