show file errors in toast

Author: williamstein

src/packages/frontend/frame-editors/code-editor/actions.ts

@@ -25,7 +25,6 @@ import { delay } from "awaiting";
 import * as CodeMirror from "codemirror";
 import { List, Map, fromJS, Set as iSet } from "immutable";
 import { debounce } from "lodash";
-
 import {
   Actions as BaseActions,
   Rendered,
@@ -74,6 +73,7 @@ import {
   history_path,
   len,
   uuid,
+  path_split,
 } from "@cocalc/util/misc";
 import { reuseInFlight } from "@cocalc/util/reuse-in-flight";
 import { set_account_table } from "../../account/util";
@@ -111,6 +111,7 @@ import { test_line } from "./simulate_typing";
 import { misspelled_words } from "./spell-check";
 import { log_opened_time } from "@cocalc/frontend/project/open-file";
 import { ensure_project_running } from "@cocalc/frontend/project/project-start-warning";
+import { alert_message } from "@cocalc/frontend/alerts";
 
 interface gutterMarkerParams {
   line: number;
@@ -1238,7 +1239,7 @@ export class Actions<
     // several other formatting actions.
     // Doing this automatically is fraught with error, since cursors aren't precise...
     if (explicit) {
-      if (!await this.ensureProjectIsRunning(`save ${this.path} to disk`)) {
+      if (!(await this.ensureProjectIsRunning(`save ${this.path} to disk`))) {
         return;
       }
       const account: any = this.redux.getStore("account");
@@ -1916,31 +1917,30 @@ export class Actions<
     }
   }
 
-  // big scary error shown at top
-  public set_error(
-    error?: object | string,
-    style?: ErrorStyles,
-    _id?: string, // id - not currently used, but would be for frame-specific error.
-  ): void {
+  private formatError = (error?: object | string): string | undefined => {
     if (error === undefined) {
-      this.setState({ error });
-    } else {
-      if (typeof error === "object") {
-        const e = (error as any).message;
-        if (e === undefined) {
-          let e = JSON.stringify(error);
-          if (e === "{}") {
-            e = `${error}`;
-          }
-        }
-        if (typeof e != "string") throw Error("bug"); // make typescript happy
-        error = e;
-      }
-      if (IS_TIMEOUT_CALLING_PROJECT(error)) {
-        error = TIMEOUT_CALLING_PROJECT_MSG;
+      return "";
+    }
+    if (IS_TIMEOUT_CALLING_PROJECT(error)) {
+      return TIMEOUT_CALLING_PROJECT_MSG;
+    }
+    if (typeof error == "string") {
+      return error;
+    }
+    const e = (error as any).message;
+    if (e === undefined) {
+      let e = JSON.stringify(error);
+      if (e === "{}") {
+        e = `${error}`;
       }
-      this.setState({ error });
     }
+    return e;
+  };
+
+  // big scary error shown at top
+  topError(error?: object | string, style?: ErrorStyles): void {
+    const e = this.formatError(error);
+    this.setState({ error: e });
 
     switch (style) {
       case "monospace":
@@ -1951,6 +1951,31 @@ export class Actions<
     }
   }
 
+  set_error(error?: object | string, _style?: ErrorStyles): void {
+    // show the error at the a toast if this path is the focused one; otherwise,
+    // do not show the error at all.  We have shown a lot of useless errors
+    //  and now we will show less, and in a minimally harmful way.
+    if (this.redux.getStore("page").get("active_top_tab") != this.project_id) {
+      return;
+    }
+    if (
+      !this.redux
+        .getProjectStore(this.project_id)
+        .get("active_project_tab")
+        .includes(this.path)
+    ) {
+      return;
+    }
+    const e = this.formatError(error);
+    if (e) {
+      alert_message({
+        type: "error",
+        title: path_split(this.path).tail,
+        message: e,
+      });
+    }
+  }
+
   // status - little status message shown at bottom.
   // timeout -- if status message hasn't changed after
   // this long, then blank it.

src/packages/frontend/frame-editors/jupyter-editor/cell-notebook/actions.ts

@@ -803,7 +803,7 @@ export class NotebookFrameActions {
   }
 
   public set_error(error: string): void {
-    this.frame_tree_actions.set_error(error, undefined, this.frame_id);
+    this.frame_tree_actions.set_error(error);
   }
 
   public async command(name: string): Promise<void> {