fix #7677 -- never set image tag for compute server unless explicitly requested; unset on image change

Author: williamstein

src/packages/frontend/compute/google-cloud-config.tsx

@@ -1411,9 +1411,11 @@ function ensureConsistentImage(configuration, changes, IMAGES) {
   if (gpu && !gpuSelected) {
     // GPU image but non-GPU machine -- change image to non-GPU
     configuration["image"] = changes["image"] = "python";
+    configuration["tag"] = changes["tag"] = null;
   } else if (!gpu && gpuSelected) {
     // GPU machine but not image -- change image to pytorch
     configuration["image"] = changes["image"] = "pytorch";
+    configuration["tag"] = changes["tag"] = null;
   }
 }
 

src/packages/frontend/compute/select-image.tsx

@@ -58,8 +58,7 @@ export default function SelectImage({
   useEffect(() => {
     setValue(configuration.image);
   }, [configuration.image]);
-  // [ ] TODO: MAYBE we should allow gpu/non-gpu options in
-  // all cases, but just suggest one or the other?
+
   const options = useMemo(() => {
     if (IMAGES == null || typeof IMAGES == "string") {
       return [];
@@ -105,10 +104,12 @@ export default function SelectImage({
         options={options}
         onChange={(val) => {
           setValue(val);
-          const x: any = { image: val };
+          const x = {
+            image: val,
+            tag: null,
+          };
           for (const option of options) {
             if (option.value == val) {
-              x.tag = option.tag;
               setDockerSizeGb(option.dockerSizeGb);
               break;
             }