Commit c1228b2
Release Manager
gh-40628: support ideals over finite fields where p > 2^29
<!-- ^ Please provide a concise and informative title. -->
Currently, doing `Ideal(...).variety()` on an ideal over a multivariate
polynomial over a finite field with p > 2^29, gives us this:
```
RuntimeError: error in Singular function call 'triangLfak':
not implemented for rings with rings as coeffients
error occurred in or before triang.lib::faktorisiere_letzten line 1091:
` factors = factorize(h[nh],1);`
leaving triang.lib::faktorisiere_letzten (1087)
leaving triang.lib::triangLbas (262)
```
This PR uses the toy implementation of `.variety` in that cases
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes #12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes #12345". -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - #12345: short description why this is a dependency -->
<!-- - #34567: ... -->
URL: #40628
Reported by: Arthur
Reviewer(s): Arthur, user202729, Vincent Macri
File tree
2 files changed
+25
-4
lines changed- src/sage/rings/polynomial
2 files changed
+25
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2760 | 2760 | | |
2761 | 2761 | | |
2762 | 2762 | | |
| 2763 | + | |
| 2764 | + | |
| 2765 | + | |
| 2766 | + | |
| 2767 | + | |
| 2768 | + | |
| 2769 | + | |
| 2770 | + | |
| 2771 | + | |
| 2772 | + | |
| 2773 | + | |
| 2774 | + | |
| 2775 | + | |
| 2776 | + | |
| 2777 | + | |
2763 | 2778 | | |
2764 | 2779 | | |
2765 | 2780 | | |
| |||
2802 | 2817 | | |
2803 | 2818 | | |
2804 | 2819 | | |
2805 | | - | |
2806 | | - | |
2807 | | - | |
2808 | | - | |
| 2820 | + | |
| 2821 | + | |
| 2822 | + | |
| 2823 | + | |
| 2824 | + | |
| 2825 | + | |
| 2826 | + | |
| 2827 | + | |
2809 | 2828 | | |
2810 | 2829 | | |
2811 | 2830 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4662 | 4662 | | |
4663 | 4663 | | |
4664 | 4664 | | |
| 4665 | + | |
| 4666 | + | |
4665 | 4667 | | |
4666 | 4668 | | |
4667 | 4669 | | |
| |||
0 commit comments